Add remove user groups option to group chat context menu #16360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (26)
|
iurimatias
changed the base branch from
master
to
refactor/16286_refactor_profile_context_menu
iurimatias
requested review from
a team,
jrainville,
glitchminer and
micieslak
and removed request for
a team
jrainville
reviewed
Sep 18, 2024
| @@ -212,6 +214,10 @@ Item { | |||
| const contactDetails = publicKey === "" ? {} : Utils.getContactDetailsAsJson(publicKey, true, true) | |||
| Global.blockContactRequested(publicKey, contactDetails) | |||
| } | |||
| onRemoveFromGroup: (publicKey) => { | |||
| const chatId = root.store.chatCommunitySectionModule.activeItem.id | |||
| root.store.chatCommunitySectionModule.removeMemberFromGroupChat("", chatId, publicKey) | |||
There was a problem hiding this comment.
Just a suggestion, but we could create a removeMemberFromActiveGroupChat(publicKey) function in the store that would do the two calls above and hide some of the logic. No need to use chatCommunitySectionModule in the component that way.
There was a problem hiding this comment.
Yes, that's also important rule (affects testing) that context properties should be accessed only from stores and not exposed from them directly. So chatCommunitySectionModule should not be used (and even accessible) from root.store directly like root.store.chatCommunitySectionModule.
| @@ -1214,6 +1216,10 @@ Loader { | |||
| const contactDetails = publicKey === "" ? {} : Utils.getContactDetailsAsJson(publicKey, true, true) | |||
| Global.blockContactRequested(publicKey, contactDetails) | |||
| } | |||
| onRemoveFromGroup: (publicKey) => { | |||
| const chatId = root.rootStore.chatCommunitySectionModule.activeItem.id | |||
| root.rootStore.chatCommunitySectionModule.removeMemberFromGroupChat("", chatId, publicKey) | |||
iurimatias
force-pushed
the
refactor/16286_refactor_profile_context_menu
branch
from
93f17b2
to
8e0b619
Compare
jrainville
approved these changes
Sep 19, 2024
caybro
reviewed
Sep 19, 2024
iurimatias
force-pushed
the
refactor/16286_refactor_profile_context_menu
branch
from
8e0b619
to
e423081
Compare
iurimatias
force-pushed
the
feature/16130_remove_user_groups
branch
from
517e651
to
e74aa19
Compare
iurimatias
force-pushed
the
refactor/16286_refactor_profile_context_menu
branch
from
0d80878
to
a09b773
Compare
iurimatias
force-pushed
the
feature/16130_remove_user_groups
branch
from
e74aa19
to
5cf658b
Compare
caybro
approved these changes
Sep 23, 2024
glitchminer
requested changes
Sep 24, 2024
Base automatically changed from
refactor/16286_refactor_profile_context_menu
to
master
September 24, 2024 14:04
iurimatias
force-pushed
the
feature/16130_remove_user_groups
branch
from
5cf658b
to
d1d7199
Compare
feature: add remove from group option to group chats refactor ProfileContextMenu to make it a functional component refactor ProfileContextMenu to make it a functional component This refactor ProfileContextMenu to make it a functional component by: refactored out direct calls to backend, and passing backend data structures and moved this logic to the callers, also refactored common calls between the callers common types of context menus have been extracted to their sub components which removes a lot of logic too and makes the behaviour very clear user verification workflow (which was already disabled) has been removed refactor: use signals and call singletons on the parent instead remove unused code for now from profile context menu refactor profile context menu into two components; add property to storybook extract blocked profile context menu and self profile context menu use profileType instead of individual bools refactor to pass trustStatus as an argument make contact type a parameter remove unnecessary method from RegularProfileContextMenu add ensVerified property to ProfileContextMenu components add onlineStatus property to ProfileContextMenu components move ProfileContextMenu storybook controls to the right sidebar move contactDetails logic up from the view add local nickname property to ProfileContextMenu components fix issue with missing signal; fix logs in storybook use constant for profileType instead of string refactor common code into a single method refactor getProfileContext remove references to contactDetails which are not longer needed remove unnecessary comments fix bridged constant refactor into a single ProfileContextMenu component refactor into a single ProfileContextMenu component refactor into a single ProfileContextMenu component simplify imports remove unused store field move methods from utils to contacts store remove onClosed signal remove unused param feature: add remove from group option to group chats feature: add remove from group option to group chats add isAdmin property move removeMemberFromGroupChat to root store hide remove from group option from message context menu
iurimatias
force-pushed
the
feature/16130_remove_user_groups
branch
from
d1d7199
to
3100535
Compare
glitchminer
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16130
requires #16334
What does the PR do
Adds "Remove from group" to context menu in group chats
Affected areas
Should only affect group chats
Screenshot of functionality (including design for comparison)
How to test
OR
expected: user is removed from the group and the message "user has left the group" is displayed for everyone
Risk
Worst case scenario this option appears somewhere it shouldn't (like community member list) and clicking it has unknown behaviour (probably not happens)