Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/16286 refactor profile context menu #16334

Merged
merged 2 commits into from
Sep 24, 2024

Commits on Sep 23, 2024

  1. refactor ProfileContextMenu to make it a functional component

    refactor ProfileContextMenu to make it a functional component
    
    refactor ProfileContextMenu to make it a functional component
    
    refactor ProfileContextMenu to make it a functional component
    
    This refactor ProfileContextMenu to make it a functional component by:
    
    refactored out direct calls to backend, and passing backend data structures and moved this logic to the callers, also refactored common calls between the callers
    common types of context menus have been extracted to their sub components which removes a lot of logic too and makes the behaviour very clear
    user verification workflow (which was already disabled) has been removed
    
    refactor: use signals and call singletons on the parent instead
    
    remove unused code for now from profile context menu
    
    refactor profile context menu into two components; add property to storybook
    
    extract blocked profile context menu and self profile context menu
    
    use profileType instead of individual bools
    
    refactor to pass trustStatus as an argument
    
    make contact type a parameter
    
    remove unnecessary method from RegularProfileContextMenu
    
    add ensVerified property to ProfileContextMenu components
    
    add onlineStatus property to ProfileContextMenu components
    
    move ProfileContextMenu storybook controls to the right sidebar
    
    move contactDetails logic up from the view
    
    add local nickname property to ProfileContextMenu components
    
    fix issue with missing signal; fix logs in storybook
    
    use constant for profileType instead of string
    
    refactor common code into a single method
    
    refactor getProfileContext
    
    remove references to contactDetails which are not longer needed
    
    remove unnecessary comments
    
    fix bridged constant
    
    refactor into a single ProfileContextMenu component
    
    refactor into a single ProfileContextMenu component
    
    refactor into a single ProfileContextMenu component
    
    simplify imports
    
    remove unused store field
    
    move methods from utils to contacts store
    
    remove onClosed signal
    
    remove unused param
    
    rename ProfileContextMenu variables
    
    simplify signals in ProfileContextMenu
    
    remove ;
    
    refactor: do early return
    
    simplify ifs
    
    move ProfileContextMenu to its own storybook page
    
    fix wrong params
    
    fix profile context menu separator
    
    add missing signals to profile context menu on the members tab panel
    iurimatias committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a09b773 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c979956 View commit details
    Browse the repository at this point in the history