Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch nodes which support new PoW #1641

Closed
oskarth opened this issue Oct 14, 2019 · 5 comments
Closed

Launch nodes which support new PoW #1641

oskarth opened this issue Oct 14, 2019 · 5 comments

Comments

@oskarth
Copy link
Contributor

oskarth commented Oct 14, 2019

Problem

As a node runner, I want to be able to run with the EIP627 spec compliant and updated PoW calculation. Additionally, I want to disconnect nodes that don't satisfy my powRequirement.

Currently, due to mismatching PoW calculations, old pow calculations that seem to meet powRequirements actually don't (indeterministic).

What this means in practice is that all Status nodes are sending what seems like bad envelopes from new/spec compliant nodes point of view.

Before v1, we don't want to break things for existing users. For v1, we want to switch over and use only new pow checks.

Implementation

Deploy a separate fleet which has some nodes that do pow calculation using new fixed algorithm.

There might be some edge cases wrt mailservers and stickyness, but we don't need to expose this to status-react yet.

Also bump status-go version so it is visible what type of peer you are connected to.

Acceptance Criteria

I can run a node with new pow calculation and not disconnect all nodes in the Status network.

Notes

See conversation in #core-infra

Future Steps

  • Update specs
  • Update status-react
  • Figure out how to deal with mailservers gracefully

^ @adambabik

@adambabik
Copy link
Contributor

I would suggest to upgrade mailservers and server nodes on eth.staging and test whether everything works as expected. If so, maybe we can just use eth.staging instead of creating a new fleet to develop V1.

That would mean broken message passing between pre-V1 and V1 versions but the same would happen with a new fleet.

@oskarth
Copy link
Contributor Author

oskarth commented Oct 14, 2019

Sounds good to me!

@adambabik
Copy link
Contributor

eth.staging fleet is updated. I tested it with status-console-client and messages are exchanged properly.

@adambabik
Copy link
Contributor

I am gonna test mailservers because @jakubgs discovered some problems.

@adambabik
Copy link
Contributor

eth.staging runs new PoW and it's confirmed the messages are exchanged properly between clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants