Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eth.staging as a default fleet for development and nightlies #9216

Closed
adambabik opened this issue Oct 15, 2019 · 7 comments
Closed

Use eth.staging as a default fleet for development and nightlies #9216

adambabik opened this issue Oct 15, 2019 · 7 comments
Assignees
Labels
feature feature requests

Comments

@adambabik
Copy link
Contributor

Feature Issue

After upgrade of geth and Whisper, the algorithm to calculate envelope's PoW in Whisper changed. It means that sending a message from a client before and after the change might calculate PoW totally different and messages won't be exchanged.

In order to fix it, all clients and forwarding Whisper nodes have to use the same Whisper PoW algorithm.

That's why in status-im/status-go#1641 we upgraded eth.staging fleet to the newest status-go version. It means that eth.staging and the current status-react develop builds use the same Whisper PoW algorithm and messages can be properly exchanged.

User Story

As a developer, I would like to use a fleet which runs Whisper nodes compatible with the status-react develop builds.

Acceptance Criteria

  • All messages sent between the status-react develop clients have to be received
  • status-react develop builds use eth.staging as a default fleet
@adambabik adambabik added the feature feature requests label Oct 15, 2019
@adambabik
Copy link
Contributor Author

cc @oskarth

@oskarth
Copy link
Contributor

oskarth commented Oct 18, 2019

Is anyone handling this in @status-im/status-core (also cc @andremedeiros in case you aren't in that team yet)?

@jakubgs
Copy link
Member

jakubgs commented Oct 18, 2019

This can be easily changed by using the FLEET parameter in Jenkins:
https://ci.status.im/job/status-react/job/manual/build
Or just modifying the default value here:
https://github.com/status-im/status-react/blob/647bde7c6b46faf0eb4bf240457b385255275380/.env.nightly#L6
And other .env.* files.

@jakubgs
Copy link
Member

jakubgs commented Oct 18, 2019

Although do take into account that the eth.staging fleet is much smaller than the eth.beta one. Though considering our small usage it should be fine.

@oskarth
Copy link
Contributor

oskarth commented Oct 21, 2019

It seems like the app might be ignoring this setting and using beta fleet anyway

I will ask eric, it might be that the client is not switching fleet correctly
that might be an issue on our side, settings might be saved but not applied, since we moved them to status-go
so the client might still be hitting the beta fleet, I am on something else but could take a look at this later, but I'd rather focus on what I am currently finishing off, so if anyone would like to investigate by all means :)

@cammellos
Copy link
Contributor

cc @rachelhamlin

@cammellos
Copy link
Contributor

closed via #9379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

No branches or pull requests

4 participants