Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to keep non-go files to dep #569

Closed
mandrigin opened this issue Jan 24, 2018 · 1 comment
Closed

Add an option to keep non-go files to dep #569

mandrigin opened this issue Jan 24, 2018 · 1 comment

Comments

@mandrigin
Copy link
Contributor

Problem

Currently dep prune removes non-go files from all the packages. That doesn't work for us because some packages we use have C sources in it. In the next release of dep there would be an option to keep non-go files intact.

When it is released, let's use it and use dep prune to keep our vendor folder nice and slim.

Acceptance Criteria

  1. Essential non-go files aren't touched when dep prune is called.
  2. Gopkg.toml has [prune] section with options set.
  3. Updated (after dep prune) vendor folder is committed. Tests are removed, unused packages are removed.
  4. Tests pass and the library still builds.
@dshulyak
Copy link
Contributor

was implemented in #551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants