Remove unused packages and tests #570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use commits from `go-ethereum@release/1.7` for most of the dependencies.
Dep with required fix was released: https://golang.github.io/dep/blog/2018/01/23/announce-v0.4.0.html
mandrigin
suggested changes
Jan 24, 2018
| to be in-sync there. We want to reduce the regression scope. | ||
| Hence, we pin down all the dependencies of `go-ethereum` with SHAs in `Gopkg.toml` when | ||
| importing a new version of upstream. (This is considered a bad practice for | ||
| `dep` but we are willing |
There was a problem hiding this comment.
It is based on an outdated version of #551. I think it is worth rebasing.
There was a problem hiding this comment.
I will cherry pick on develop when your change will be merged
There was a problem hiding this comment.
ah, ok. but maybe I should cherry-pick this one to my branch instead? so we don't add and then remove tons of files?
There was a problem hiding this comment.
good idea, i will close this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #569
Follow up for: #551
Dep with required fix was released: https://golang.github.io/dep/blog/2018/01/23/announce-v0.4.0.html