Return always json struct #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
cammellos
force-pushed
the
bug/return-json
branch
from
e85a58f
to
43cb786
Compare
adambabik
approved these changes
Sep 28, 2018
adambabik
reviewed
Sep 28, 2018
lib/library.go
Outdated
| @@ -106,7 +106,14 @@ func VerifyGroupMembershipSignatures(signaturePairsStr *C.char) *C.char { | |||
| return makeJSONResponse(err) | |||
| } | |||
|
|
|||
| return nil | |||
| data, err := json.Marshal(struct { | |||
| Success bool | |||
There was a problem hiding this comment.
Success bool `json:"success"`
if you don't want it to be capitalized.
cammellos
force-pushed
the
bug/return-json
branch
from
43cb786
to
826de92
Compare
pedropombeiro
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be a difference on how desktop and android/ios handles callbacks from status-go, whereby returning
nilin desktop is cast to"",making the JSON parser complain about it.It seems sensible to always return some JSON so the type is always the same.