DeleteAccount method #1671
Closed
DeleteAccount method #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (3)
|
rasom
force-pushed
the
delete-account
branch
from
a297050
to
91efdb9
Compare
cammellos
reviewed
Nov 12, 2019
api/backend.go
Outdated
| } | ||
|
|
||
| path := accountDBPath(b.rootDataDir, address) | ||
| err = os.RemoveAll(path) |
There was a problem hiding this comment.
you can just do return os.RemoveAll(path) I believe
| @@ -383,6 +383,24 @@ func SaveAccountAndLogin(accountData, password, configJSON, subaccountData *C.ch | |||
| return makeJSONResponse(nil) | |||
| } | |||
|
|
|||
| // DeleteAccount delete account's database and delete account from multiaccount database | |||
| //export DeleteAccount | |||
| func DeleteAccount(addressChars *C.char) *C.char { | |||
There was a problem hiding this comment.
Can we use RPC in this case? I believe the consensus is to use RPC when poissble
There was a problem hiding this comment.
hm, yes I think we can
DeleteAccount method is added, it deletes account from multiaccounts database and also removes account's DB file. The method is needed for keycard reseting functionality. status-im/status-mobile#9229
rasom
force-pushed
the
delete-account
branch
from
91efdb9
to
bde7022
Compare
adambabik
reviewed
Nov 12, 2019
| return b.multiaccountsDB.DeleteAccount(address) | ||
| } | ||
|
|
||
| func accountDBPath(root string, address common.Address) string { |
There was a problem hiding this comment.
We can move it at the bottom of the file.
jakubgs
force-pushed
the
develop
branch
4 times, most recently
from
a726462
to
330d177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeleteAccount method is added, it deletes account from
multiaccounts database and also removes account's DB file.
The method is needed for keycard reseting functionality.
status-im/status-mobile#9229