fix old messages marked as seen #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (12)
|
flexsurfer
force-pushed
the
bug/fix-old-message-marked-as-seen
branch
from
a0fc884
to
90a468a
Compare
Samyoul
approved these changes
Jun 16, 2022
protocol/messenger_handler.go
Outdated
| if chat.ReadMessagesAtClockValue > state.CurrentMessageState.WhisperTimestamp { | ||
| receivedMessage.Seen = true | ||
| } | ||
| // This will prevent older messages to be marked as seen, currently the UI/UX behavior is unspecified, |
There was a problem hiding this comment.
Perhaps add a TODO to flag that this needs to be address in the future?
There was a problem hiding this comment.
it didn't work, @Samyoul pls review again, thank you
flexsurfer
force-pushed
the
bug/fix-old-message-marked-as-seen
branch
from
90a468a
to
aa80b32
Compare
flexsurfer
requested review from
Samyoul and
cammellos
and removed request for
cammellos
flexsurfer
force-pushed
the
bug/fix-old-message-marked-as-seen
branch
from
b133e02
to
a429480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix old messages marked as seen