-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove group members #3011
Remove group members #3011
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (3)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM however there are some details/APIs in this PR that I'm not familiar with, so I'll defer to the other reviewers to double check the correctness here.
Also, bonus points if there was a test for this new API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @OmarBasem! looks good, only thing, could you please add some tests for the new functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic of the new endpoint is almost the same as for RemoveMemberFromGroupChat
. Could you please remove the duplication by making RemoveMemberFromGroupChat
use RemoveMembersFromGroupChat
?
func (m *Messenger) RemoveMemberFromGroupChat(ctx context.Context, chatID string, member string) (*MessengerResponse, error) {
return m.RemoveMembersFromGroupChat(ctx, chatID, []string{member})
}
Sure! Just to confirm, do you mean |
Sure, I will! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to have a test that removes multiple members, but it's ok I guess, also don't forget to bump the version (this is breaking change, so you can bump the y
)
Great work!
Fixes #3009
This PR adds a method to remove a list of members from a group at once.
Needed by: status-im/status-mobile#14494