use timesource(synced) to generate/validate server cert time #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfrank
requested review from
cammellos,
Samyoul,
igor-sirotin and
siddarthkay
Jenkins BuildsClick to see older builds (19)
|
qfrank
force-pushed
the
chore/use-timesource-to-generate-cert
branch
from
ec97d9e to
d6bafce
Compare
siddarthkay
approved these changes
Oct 30, 2023
qfrank
force-pushed
the
chore/use-timesource-to-generate-cert
branch
3 times, most recently
from
9270352 to
70cd023
Compare
qfrank
force-pushed
the
chore/use-timesource-to-generate-cert
branch
from
d196eea to
35c3d6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
major changes:
timesourceto fill the time of the certtimesourceto validate cert timewith this PR, we can account for potential time inaccuracies in devices, ensuring that certificate validation is not adversely affected by devices with incorrect system times.
relate comment
status: ready.