Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/duplicate accept cr messages #4367

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix/duplicate accept cr messages #4367

merged 2 commits into from
Dec 5, 2023

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Nov 23, 2023

this PR fix mobile issue

@qfrank qfrank self-assigned this Nov 23, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Nov 23, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (25)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 95cf43d #1 2023-11-23 06:31:50 ~4 min ios 📦zip
✔️ 95cf43d #1 2023-11-23 06:35:50 ~8 min linux 📦zip
✔️ a7026f3 #2 2023-11-23 06:36:28 ~2 min ios 📦zip
✔️ a7026f3 #2 2023-11-23 06:38:57 ~3 min linux 📦zip
✔️ a7026f3 #2 2023-11-23 06:40:13 ~2 min android 📦aar
✖️ a7026f3 #2 2023-11-23 07:30:12 ~22 min tests 📄log
✖️ a7026f3 #3 2023-11-23 12:07:59 ~28 min tests 📄log
✖️ a7026f3 #4 2023-11-23 12:52:19 ~34 min tests 📄log
✔️ 019eb7b #3 2023-11-24 09:19:36 ~3 min ios 📦zip
✔️ 019eb7b #3 2023-11-24 09:19:51 ~3 min linux 📦zip
✔️ 019eb7b #3 2023-11-24 09:21:46 ~5 min android 📦aar
✖️ 019eb7b #6 2023-11-24 09:29:50 ~13 min tests 📄log
✔️ 1dd1683 #4 2023-11-28 08:03:23 ~4 min ios 📦zip
✔️ 1dd1683 #4 2023-11-28 08:05:19 ~6 min linux 📦zip
✔️ 1dd1683 #4 2023-11-28 08:06:55 ~7 min android 📦aar
✖️ 1dd1683 #7 2023-11-28 08:35:34 ~36 min tests 📄log
✔️ 718b8ca #5 2023-11-29 05:29:23 ~2 min android 📦aar
✔️ 718b8ca #5 2023-11-29 05:30:44 ~3 min linux 📦zip
✖️ 718b8ca #8 2023-11-29 06:01:25 ~34 min tests 📄log
✔️ 718b8ca #9 2023-11-29 11:08:47 ~35 min tests 📄log
✔️ 718b8ca #5 2023-11-29 14:20:50 ~8 hr 53 min ios 📦zip
✔️ bc532a8 #6 2023-12-01 08:34:48 ~4 min linux 📦zip
✔️ bc532a8 #6 2023-12-01 08:34:53 ~4 min ios 📦zip
✔️ bc532a8 #6 2023-12-01 08:35:57 ~5 min android 📦aar
✖️ bc532a8 #10 2023-12-01 08:37:56 ~7 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f36dc0c #7 2023-12-04 03:47:24 ~2 min android 📦aar
✔️ f36dc0c #7 2023-12-04 03:48:04 ~3 min ios 📦zip
✔️ f36dc0c #7 2023-12-04 03:48:11 ~3 min linux 📦zip
✔️ f36dc0c #11 2023-12-04 04:19:30 ~34 min tests 📄log
✔️ 800f36a #8 2023-12-05 03:02:35 ~1 min linux 📦zip
✔️ 800f36a #8 2023-12-05 03:03:22 ~2 min android 📦aar
✔️ 800f36a #8 2023-12-05 03:04:21 ~3 min ios 📦zip
✖️ 800f36a #12 2023-12-05 03:14:26 ~13 min tests 📄log
✖️ 800f36a #13 2023-12-05 03:21:14 ~3 min tests 📄log
✔️ 800f36a #14 2023-12-05 04:06:48 ~32 min tests 📄log

@qfrank qfrank force-pushed the fix/duplicate_accept_CR_messages branch from 95cf43d to a7026f3 Compare November 23, 2023 06:33
MishkaRogachev
MishkaRogachev approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MishkaRogachev MishkaRogachev mentioned this pull request Nov 23, 2023
Open
igor-sirotin
igor-sirotin approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding, thank you!

protocol/messenger_sync_contact_request_decision_test.go Outdated Show resolved Hide resolved
protocol/messenger_sync_contact_request_decision_test.go Outdated Show resolved Hide resolved
protocol/messenger_sync_contact_request_decision_test.go Outdated Show resolved Hide resolved
@qfrank qfrank force-pushed the fix/duplicate_accept_CR_messages branch from 019eb7b to 1dd1683 Compare November 28, 2023 07:58
igor-sirotin
igor-sirotin approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the changes!
We saved ~8 seconds of tests runtime 💪

@qfrank qfrank force-pushed the fix/duplicate_accept_CR_messages branch 3 times, most recently from bc532a8 to f36dc0c Compare December 4, 2023 03:44
@qfrank qfrank force-pushed the fix/duplicate_accept_CR_messages branch from f36dc0c to 800f36a Compare December 5, 2023 03:00
@qfrank qfrank merged commit d7e7792 into develop Dec 5, 2023
7 checks passed
@qfrank qfrank deleted the fix/duplicate_accept_CR_messages branch December 5, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-sirotin igor-sirotin igor-sirotin approved these changes

@MishkaRogachev MishkaRogachev MishkaRogachev approved these changes

@cammellos cammellos Awaiting requested review from cammellos

@vitvly vitvly Awaiting requested review from vitvly

Assignees

@qfrank qfrank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate 'Contact Added' Notifications When Pair-Device User Accepts Request
4 participants
@qfrank @status-im-auto @MishkaRogachev @igor-sirotin