fix(bridge)_: fix bridge replies not working when they come from Discord #5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (20)
|
jrainville
force-pushed
the
fix/bridge-replies
branch
from
1c5288b
to
d93e6a9
Compare
jrainville
changed the title
siddarthkay
reviewed
Sep 13, 2024
jrainville
force-pushed
the
fix/bridge-replies
branch
from
d93e6a9
to
2552a78
Compare
siddarthkay
approved these changes
Sep 14, 2024
|
@jrainville a bunch of tests are failing, including 
I think it's only |
igor-sirotin
approved these changes
Sep 19, 2024
osmaczko
approved these changes
Sep 20, 2024
jrainville
force-pushed
the
fix/bridge-replies
branch
from
2552a78
to
ba8236f
Compare
|
@igor-sirotin @osmaczko re-asking review because I removed even more code when I fixed the test. I also tested again with the real app to make sure my assumptions were all right and it still all works. Proof: Also, I tested closing the app and sending a lot of messages and replies, so that it would fetch out of order to confirm that it still managed to populate the replies even out of order and it worked: For example, the |
jrainville
force-pushed
the
fix/bridge-replies
branch
from
ba8236f
to
c9023c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #5830 +/- ##
===========================================
+ Coverage 45.60% 46.02% +0.42%
===========================================
Files 884 884
Lines 157168 157126 -42
===========================================
+ Hits 71674 72325 +651
+ Misses 77245 76503 -742
- Partials 8249 8298 +49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
igor-sirotin
approved these changes
Sep 27, 2024
protocol/persistence_test.go
Outdated
| @@ -1995,18 +1995,18 @@ func TestBridgeMessageReplies(t *testing.T) { | |||
| err = insertMinimalBridgeMessage(p, "444", "4", "3") | |||
| require.NoError(t, err) | |||
|
|
|||
| // status message "222" should have reply_to = "111" | |||
| // status message "222" should have reply_to =" 1" because it's a discord message to another discord message | |||
There was a problem hiding this comment.
These message ids are so unobvious, impossible to read the test really 😵💫
Fixes status-im/status-desktop#16323 The problem was that the code expected to receive the Discord message ID, but the bridge is smart enough to return the Status message ID already, so there is no need to try and convert it. There were also a couple issues in the bridge code itself.
jrainville
force-pushed
the
fix/bridge-replies
branch
from
c9023c0
to
860e758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes status-im/status-desktop#16323
The problem was that the code expected to receive the Discord message ID, but the bridge is smart enough to return the Status message ID already, so there is no need to try and convert it.
There were also a couple issues in the bridge code itself.
Bridge PR: status-im/matterbridge#18