Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat_: dial, drop and retrieve connected peers #6013

Merged
merged 13 commits into from
Oct 30, 2024

Conversation

gabrielmer
Copy link

@gabrielmer gabrielmer commented Oct 30, 2024

Opening this PR again as some force push to the base branch broke the other PRs diff and didn't let me rebase, so cherry-picked the same commits on top of this one

Integrating and implementing features to dial, drop and retrieve connected peers.

Important changes:

  • implemented DialPeer(), DropPeer() and PeerCount() functions
  • renamed GetNumConnectedPeers to GetNumConnectedRelayPeers
  • added test for dialing feature
  • fixed flaky test
  • updated nwaku submodule

Issue: waku-org/nwaku#3076

Copy link

github-actions bot commented Oct 30, 2024

We require commits to follow the Conventional Commits, but with _ for non-breaking changes.
Please fix these commit messages:

fixing test
comment and deleting unnecessary function
remove unnecessary test
don't require protocol in dialpeer for status-go
updating nwaku version
adding tests for connect
fixing test and adding missing procs
requiring protocol for dial
implementing feedback
fix flaky test
changing function name to specify that only connected relay peers are returned
initial dialPeer implementation
implementing PeerCount and DropPeer

@status-im-auto
Copy link
Member

status-im-auto commented Oct 30, 2024

Jenkins Builds

Click to see older builds (41)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 3982b8d #1 2024-10-30 12:11:43 ~1 min tests 📄log
✖️ 3982b8d #1 2024-10-30 12:13:53 ~4 min tests-rpc 📄log
✔️ 3982b8d #1 2024-10-30 12:15:00 ~5 min linux 📦zip
✔️ 3982b8d #1 2024-10-30 12:15:35 ~5 min macos 📦zip
✔️ 3982b8d #1 2024-10-30 12:15:58 ~6 min android 📦aar
✔️ 3982b8d #1 2024-10-30 12:16:38 ~6 min ios 📦zip
✔️ 3982b8d #1 2024-10-30 12:21:07 ~11 min macos 📦zip
✖️ 3982b8d #1 2024-10-30 12:21:43 ~11 min windows 📦zip
✖️ 1a77ee1 #2 2024-10-30 12:35:53 ~3 min tests 📄log
✖️ 1a77ee1 #2 2024-10-30 12:36:16 ~3 min tests-rpc 📄log
✔️ 1a77ee1 #2 2024-10-30 12:37:16 ~4 min macos 📦zip
✔️ 1a77ee1 #2 2024-10-30 12:37:35 ~5 min linux 📦zip
✔️ 1a77ee1 #2 2024-10-30 12:38:23 ~6 min android 📦aar
✔️ 1a77ee1 #2 2024-10-30 12:40:37 ~8 min ios 📦zip
✔️ 1a77ee1 #2 2024-10-30 12:42:01 ~9 min macos 📦zip
✖️ 1a77ee1 #2 2024-10-30 12:43:06 ~10 min windows 📦zip
✔️ 8fa0180 #3 2024-10-30 12:54:21 ~12 min android 📦aar
✖️ 8fa0180 #3 2024-10-30 12:55:14 ~12 min windows 📦zip
✔️ 8fa0180 #3 2024-10-30 12:56:33 ~14 min linux 📦zip
✖️ 8fa0180 #3 2024-10-30 12:57:45 ~15 min tests 📄log
✖️ 8fa0180 #3 2024-10-30 12:58:35 ~16 min tests-rpc 📄log
✔️ 8fa0180 #3 2024-10-30 13:05:29 ~23 min ios 📦zip
✔️ 8fa0180 #3 2024-10-30 13:12:05 ~30 min macos 📦zip
✔️ 8fa0180 #3 2024-10-30 13:36:09 ~54 min macos 📦zip
✖️ 41c1c38 #4 2024-10-30 14:32:31 ~3 min tests-rpc 📄log
✖️ 41c1c38 #4 2024-10-30 14:32:48 ~3 min tests 📄log
✔️ 41c1c38 #4 2024-10-30 14:33:34 ~4 min macos 📦zip
✔️ 41c1c38 #4 2024-10-30 14:33:40 ~4 min linux 📦zip
✔️ 41c1c38 #4 2024-10-30 14:34:20 ~5 min android 📦aar
✔️ 41c1c38 #4 2024-10-30 14:36:05 ~7 min ios 📦zip
✔️ 41c1c38 #4 2024-10-30 14:36:11 ~7 min macos 📦zip
✖️ 41c1c38 #4 2024-10-30 14:40:50 ~11 min windows 📦zip
✖️ 2fa127c #5 2024-10-30 15:29:12 ~1 min tests 📄log
✖️ 2fa127c #5 2024-10-30 15:32:12 ~4 min tests-rpc 📄log
✔️ 2fa127c #5 2024-10-30 15:33:03 ~5 min macos 📦zip
✔️ 2fa127c #5 2024-10-30 15:33:37 ~6 min linux 📦zip
✔️ 2fa127c #5 2024-10-30 15:34:11 ~6 min android 📦aar
✔️ 2fa127c #5 2024-10-30 15:34:12 ~6 min ios 📦zip
✔️ 2fa127c #5 2024-10-30 15:37:59 ~10 min macos 📦zip
✖️ 2fa127c #5 2024-10-30 15:38:02 ~10 min windows 📦zip
✖️ e859f42 #6 2024-10-30 15:31:05 ~1 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ c75a3d5 #7 2024-10-30 15:33:17 ~1 min tests 📄log
✖️ c75a3d5 #6 2024-10-30 15:36:34 ~4 min tests-rpc 📄log
✔️ c75a3d5 #6 2024-10-30 15:37:56 ~4 min macos 📦zip
✔️ c75a3d5 #6 2024-10-30 15:39:06 ~4 min ios 📦zip
✔️ c75a3d5 #6 2024-10-30 15:39:31 ~5 min linux 📦zip
✔️ c75a3d5 #6 2024-10-30 15:40:45 ~6 min android 📦aar
✔️ c75a3d5 #6 2024-10-30 15:49:56 ~11 min macos 📦zip
✖️ c75a3d5 #6 2024-10-30 15:49:57 ~11 min windows 📦zip
✖️ 101cc2b #8 2024-10-30 15:45:31 ~1 min tests 📄log
✖️ 101cc2b #7 2024-10-30 15:47:53 ~4 min tests-rpc 📄log
✔️ 101cc2b #7 2024-10-30 15:48:20 ~4 min macos 📦zip
✔️ 101cc2b #7 2024-10-30 15:49:27 ~5 min ios 📦zip
✔️ 101cc2b #7 2024-10-30 15:49:47 ~6 min linux 📦zip
✔️ 101cc2b #7 2024-10-30 15:50:26 ~6 min android 📦aar
✖️ 101cc2b #7 2024-10-30 16:00:54 ~10 min windows 📦zip
✔️ 101cc2b #7 2024-10-30 16:01:10 ~11 min macos 📦zip

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (fd9d9f3) to head (c75a3d5).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/nwaku-in-status    #6013   +/-   ##
========================================================
  Coverage                     0.00%    0.00%           
========================================================
  Files                          797      797           
  Lines                       107347   107347           
========================================================
  Misses                      107347   107347           
Flag Coverage Δ
functional 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrielmer gabrielmer self-assigned this Oct 30, 2024
@gabrielmer gabrielmer changed the title feat: peers leftovers 2 feat: dial, drop and retrieve connected peers Oct 30, 2024
@gabrielmer gabrielmer marked this pull request as ready for review October 30, 2024 14:33
@gabrielmer gabrielmer changed the title feat: dial, drop and retrieve connected peers feat_: dial, drop and retrieve connected peers Oct 30, 2024
Copy link
Contributor

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! I just added a minor comment about sth we need. To be done in a separate PR in nwaku

wakuv2/nwaku_test.go Show resolved Hide resolved
@gabrielmer gabrielmer merged commit 6ac236d into feature/nwaku-in-status Oct 30, 2024
6 of 11 checks passed
@gabrielmer gabrielmer deleted the feat-peers-leftovers-2 branch October 30, 2024 16:24
richard-ramos pushed a commit that referenced this pull request Dec 18, 2024
- some minor progress to add nwaku in status-go
- nwaku.go: GetNumConnectedPeers controls when passed pubsub is empty
- waku_test.go: adapt TestWakuV2Store
- add missing shard.go
- feat_: build nwaku with nix and use build tags to choose between go-waku and nwaku (#5896)
- chore_: update nwaku
- nwaku bump (#5911)
- bump: nwaku
- chore: add USE_NWAKU env flag
- fix: build libwaku only if needed
- feat: testing discovery and dialing with nwaku integration (#5940)
- message publisher and sent verifier (#5966)
- storenode requestor for missing message retrieval and result iterator impl (#5971)
- uncomment code that would allow status-go/go-waku to compile and libwaku test to run (#5986)
- supporting peer exchange with nwaku (#5983)
- store queries
- ping
- ping storenodes using AddrInfo (#6004)
- dial, drop and retrieve connected peers  (#6013)
- integrate on-demand DNS discovery and implement discoverAndConnectPeers (#6017)
- extract libwaku calls into WakuNode struct (#6027)
- async nwaku
- remove nwaku process loop
- receive messages via relay (#6185)
- extract timeout from context
- use correct port field, get free ports and uncomment some functions (#6200)
- enable filter/lightpush/px and setup rate limits
- add protected topics
richard-ramos pushed a commit that referenced this pull request Dec 18, 2024
- some minor progress to add nwaku in status-go
- nwaku.go: GetNumConnectedPeers controls when passed pubsub is empty
- waku_test.go: adapt TestWakuV2Store
- add missing shard.go
- feat_: build nwaku with nix and use build tags to choose between go-waku and nwaku (#5896)
- chore_: update nwaku
- nwaku bump (#5911)
- bump: nwaku
- chore: add USE_NWAKU env flag
- fix: build libwaku only if needed
- feat: testing discovery and dialing with nwaku integration (#5940)
- message publisher and sent verifier (#5966)
- storenode requestor for missing message retrieval and result iterator impl (#5971)
- uncomment code that would allow status-go/go-waku to compile and libwaku test to run (#5986)
- supporting peer exchange with nwaku (#5983)
- store queries
- ping
- ping storenodes using AddrInfo (#6004)
- dial, drop and retrieve connected peers  (#6013)
- integrate on-demand DNS discovery and implement discoverAndConnectPeers (#6017)
- extract libwaku calls into WakuNode struct (#6027)
- async nwaku
- remove nwaku process loop
- receive messages via relay (#6185)
- extract timeout from context
- use correct port field, get free ports and uncomment some functions (#6200)
- enable filter/lightpush/px and setup rate limits
- add protected topics
richard-ramos pushed a commit that referenced this pull request Dec 18, 2024
- some minor progress to add nwaku in status-go
- nwaku.go: GetNumConnectedPeers controls when passed pubsub is empty
- waku_test.go: adapt TestWakuV2Store
- add missing shard.go
- feat_: build nwaku with nix and use build tags to choose between go-waku and nwaku (#5896)
- chore_: update nwaku
- nwaku bump (#5911)
- bump: nwaku
- chore: add USE_NWAKU env flag
- fix: build libwaku only if needed
- feat: testing discovery and dialing with nwaku integration (#5940)
- message publisher and sent verifier (#5966)
- storenode requestor for missing message retrieval and result iterator impl (#5971)
- uncomment code that would allow status-go/go-waku to compile and libwaku test to run (#5986)
- supporting peer exchange with nwaku (#5983)
- store queries
- ping
- ping storenodes using AddrInfo (#6004)
- dial, drop and retrieve connected peers  (#6013)
- integrate on-demand DNS discovery and implement discoverAndConnectPeers (#6017)
- extract libwaku calls into WakuNode struct (#6027)
- async nwaku
- remove nwaku process loop
- receive messages via relay (#6185)
- extract timeout from context
- use correct port field, get free ports and uncomment some functions (#6200)
- enable filter/lightpush/px and setup rate limits
- add protected topics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants