-
Notifications
You must be signed in to change notification settings - Fork 985
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: improve iOS simulator selection (#18880)
## Summary Improve iOS Simulator selection via `make run-ios` command. Currently : `make run-ios SIMULATOR="iPhone SE (3rd generation)"` would fail because of our scripts inability to deal with this kind of a pattern. This commit fixes that and makes this script more robust by storing output of `xcrun simctl list devices` in a json file `ios_simulators_list.json` and then using `jq` to properly get `UDIDs` of those simulators. This script will now also prompt you to download a simulator image if you do not already have it. The file `ios_simulators_list.json` will also help in future debugging when we want to check a quick summary of iOS simulator status of devs in the future. We also append `-verbose` to `xcodebuild` for debug `iOS` builds, this helps debugging. ## Review notes try such options -> `make run-ios SIMULATOR="iPhone SE (3rd generation)"` ## Platform - iOS
- Loading branch information
1 parent
c44ba69
commit 3c6b38a
Showing
2 changed files
with
26 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -200,3 +200,6 @@ metro-server-logs.log | |
|
||
## debug build time logs | ||
logs/ | ||
|
||
## available iOS simulators | ||
ios_simulators_list.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters