-
Notifications
You must be signed in to change notification settings - Fork 985
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: remove hermes enable condition
We recently disabled `hermes` for debug builds here -> #18675 A side effect of that is when we run `make nix-update-gradle` the `hermes` pom gets removed from `deps.list` This pom is necessary for release builds. Currently that pom exists in `deps.list` but someone may accidentally remove it when running `make nix-update-gradle` In this commit we remove the conditional implementation of `hermes` or `jsc` in `build.gradle` This ensures that the `hermes` pom we need during release builds is not removed from `deps.list`. I also ran `make nix-update-gradle` just to be sure. I compared the apk in this commit to other PRs and the size increased by 2MB. A small price to pay so that the team can run Malli locally without crashing their debug app frequently. I've added a FIXME comment in the code for when we want to cut back on bundle size later.
- Loading branch information
1 parent
2e7a9c8
commit 96376e4
Showing
3 changed files
with
83 additions
and
84 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters