Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No chats on Chats view after submit of Search input value which gives no results #10833

Closed
Serhy opened this issue Jun 17, 2020 · 1 comment · Fixed by #10835
Closed

No chats on Chats view after submit of Search input value which gives no results #10833

Serhy opened this issue Jun 17, 2020 · 1 comment · Fixed by #10835
Assignees

Comments

@Serhy
Copy link
Contributor

Serhy commented Jun 17, 2020

Bug Report

Problem

If I submit Search when there are no results and navigate out of the Chats screen (Issue1), - then we hide search input. Along with that, we give no ability to cancel chat searching and only white screen keep staying on 'Chats' view. So there are no chats at all on the 'Chats' view are shown and available for open.

Only after app re-launch everything is back and chats are displayed as expected

Additionally, (Issue2) tapping upon magnifying glass icon in the Search input produces error pop-up (I can close it and proceed using app fine)

Expected behavior

  • search input keep staying if I submit search when no results and navigate to any different view (or open (+) bottom sheet)
  • nothing happens when I tap magnifying glass icon in the Search input

Actual behavior

Screenshot 2020-06-17 at 14 36 10

Reproduction 1

  • Open Status and login to account
  • Join public chat
  • Tap on magnifying glass icon in the search input
    Actual result Issue 2 above
  • Put cursor in Search input and enter anything in search so no chats are found
  • Navigate between views
  • Join new chats and check they are visible on Chats views (including Search input)

Additional Information

  • Status version: Develop (release 1.4 is OK)
  • Operating System: Android and iOS
@Serhy Serhy added bug labels Jun 17, 2020
@Serhy
Copy link
Contributor Author

Serhy commented Jun 17, 2020

Similar issue fixed in the past
#8662

@Ferossgp Ferossgp self-assigned this Jun 17, 2020
Ferossgp added a commit that referenced this issue Jun 17, 2020
Ferossgp added a commit that referenced this issue Jun 17, 2020
Fixes #10833

Cleanup search on blur if no chat found

Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Ferossgp added a commit that referenced this issue Jun 17, 2020
Fixes #10833

Cleanup search on blur if no chat found

Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants