Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed LOG LEVEL once in release builds makes impossible to disable logs again until reopening app #10888

Closed
churik opened this issue Jun 29, 2020 · 2 comments · Fixed by #10898

Comments

@churik
Copy link
Member

churik commented Jun 29, 2020

Bug Report

Problem

By default LOG LEVEL is disabled in release builds - it means that Status.log and geth.log are empty.
But if you change it once to another log level and then change back to disable it - you'll see new entries in logs, which means that DISABLED log level is not applied.
Moreover, it is written for new multiaccounts on this build as well.
But log level is set correctly again after manual reopening app.

Expected behavior

No new entries in geth.log

Actual behavior

New entries in geth.log when user is logged out and

Reproduction

  • Open Status
  • Create new account
  • Change log level to INFO (14:15 in logs)
  • Login again and DISABLE log level
  • Login (14:25 in logs)

Additional Information

  • Status version: release 1.4.1
  • Operating System: Android, iOS

Logs

with DISABLED in log level (before change): status_logs_empty.zip
with DISABLED in log level (after change): status_logs 12.zip

@churik
Copy link
Member Author

churik commented Jun 29, 2020

as a temporary workaround IMO we can change the copy in this popup (to add that manual restarting app is required). WDYT @hesterbruikman ?
IMAGE 2020-06-29 16:47:18

@hesterbruikman
Copy link
Contributor

But log level is set correctly again after manual reopening app.
@Ferossgp how much more effort would it cost to offer a restart button on the above dialog? I don't know if something like this is possible on Android/iOS

hesterbruikman added a commit that referenced this issue Jun 30, 2020
Small change to manage #10888 

Communicates that restart is required for log change to take effect.
flexsurfer pushed a commit that referenced this issue Jul 1, 2020
Small change to manage #10888

Communicates that restart is required for log change to take effect.

Signed-off-by: andrey <motor4ik@gmail.com>
flexsurfer pushed a commit that referenced this issue Jul 1, 2020
Small change to manage #10888

Communicates that restart is required for log change to take effect.

Signed-off-by: andrey <motor4ik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants