Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quo2: implement Dropdown component to it's own spec #16456

Closed
J-Son89 opened this issue Jun 30, 2023 · 1 comment · Fixed by #17412
Closed

Quo2: implement Dropdown component to it's own spec #16456

J-Son89 opened this issue Jun 30, 2023 · 1 comment · Fixed by #17412
Assignees
@smohamedjavid
Labels
feature feature requests

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Jun 30, 2023 •
edited
Loading

Currently the dropdown component is using the button under the hood. However the designs are not 1-1.

Implement the dropdown component as it's own component as per the Figma designs
https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=56-5001&mode=design&t=Uvy1ZgKhWn6un1St-4

Design to best practices: https://github.com/status-im/status-mobile/pull/16454

Include component spec tests

Create a follow up isse to use this across the codebase and remove the unnecessary api extensions to the button component ->
blur-active?
override-before-margins
override-after-margins icon-size
icon-container-size
icon-container-rounded?
@J-Son89 J-Son89 added the feature feature requests label Jun 30, 2023
@rahulpsingh rahulpsingh self-assigned this Jul 17, 2023
@rahulpsingh rahulpsingh removed their assignment Aug 3, 2023
@ulisesmac
Copy link
Contributor

ulisesmac commented Aug 16, 2023 •
edited
Loading

Please take in consideration that the current implementation need some fixes:

@ulisesmac ulisesmac mentioned this issue Aug 16, 2023
Merged
@briansztamfater briansztamfater mentioned this issue Sep 15, 2023
Merged
@smohamedjavid smohamedjavid self-assigned this Sep 21, 2023
@smohamedjavid smohamedjavid mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smohamedjavid smohamedjavid

Labels
feature feature requests
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement dropdown component and update it's usage across the codebase status-im/status-mobile
4 participants
@rahulpsingh @smohamedjavid @J-Son89 @ulisesmac