Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Change asset action in in Token input #16953

Closed
2 tasks
briansztamfater opened this issue Aug 9, 2023 · 0 comments · Fixed by #19393
Closed
2 tasks

Implement Change asset action in in Token input #16953

briansztamfater opened this issue Aug 9, 2023 · 0 comments · Fixed by #19393
Assignees
@ulisesmac
Labels
feature feature requests wallet: Send all issues for the send page of the wallet

Comments

@briansztamfater
Copy link
Member

Feature Issue

User Story

As a user, I want to change the asset from the input so that I can send another token

Description

Figma Design 1: https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=2388-509053&mode=design&t=w7yLPvpvYH8Csnzk-4
Figma Design 2: https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=2388-507400&mode=design&t=HUmtev01QbEue8sV-4

Visual reference:

Acceptance Criteria

  • When user clicks asset icon at the left of the input, bottom sheet should appear with asset selection list
  • If use taps on an asset, bottom sheet should dismiss and change the asset on the input, recalculate fees and network breakdown
@briansztamfater briansztamfater added feature feature requests wallet: Send all issues for the send page of the wallet labels Aug 9, 2023
@ulisesmac ulisesmac self-assigned this Mar 21, 2024
@ulisesmac ulisesmac mentioned this issue Mar 25, 2024
Merged
ulisesmac added a commit that referenced this issue Apr 8, 2024
@ulisesmac
[#16953] Implement change asset action in wallet send flow (#19393)
8e31dae 
* Refactor :wallet/tokens-filtered sub to filter only when `query` is provided

* Make token input logo pressable and make components more flexible

* Change asset-list's rn/scroll-view -> gesture/scroll-view to make it scrollable on bottom-sheets

* Add bottom-sheet to edit the token to send
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulisesmac ulisesmac

Labels
feature feature requests wallet: Send all issues for the send page of the wallet
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#16953] Implement change asset action in wallet send flow status-im/status-mobile
3 participants
@briansztamfater @J-Son89 @ulisesmac