-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement QR code scanner screen #17574
Comments
cross-linking with #17658 - would be awesome to fix it in one PR |
Fixed by #17767 |
@clauxx why did you close it? This is what currently happens when you click the scan QR button: |
@alwx Right, I guess we should re-define the scope of the task (or have a different one) as the scanner was updated according to the design already (see screenshot from the "add contact" flow from messages). |
Yes, I will check it out today and update the issue. |
@alwx looking at the scope of work particularly on this screen I think we can split this into separate issues I understand in some case like scanning the QR for community, channels, profiles have not been implemented. I think its okay to limit the scope of this to just adding the qr-code scan screen and follow it up with a different pr for the differnent scenarios specified in the figma. wdyt? |
@jo-mut I think the overhead of creating different issues for different types of scanning will be bigger than doing it all in one issue, to be honest. There are certain scenarios that are a bit more complicated but most are limited to just calling one function once the QR is scanned. |
Encountered a bit of an issue with contact scanning and I think I will limit the PR only to it. |
Design: https://www.figma.com/file/eDfxTa9IoaCMUy5cLTp0ys/Shell-for-Mobile?type=design&node-id=451-18994&mode=dev
Currently, we are using a minimal version of the camera for QR code scanning.
Reported in design feedback here
The text was updated successfully, but these errors were encountered: