Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Shell Scan screen #14011

Closed
flexsurfer opened this issue Sep 15, 2022 · 3 comments · Fixed by #18677
Closed

Implement Shell Scan screen #14011

flexsurfer opened this issue Sep 15, 2022 · 3 comments · Fixed by #18677
Assignees
Labels
feature feature requests shell

Comments

@flexsurfer
Copy link
Member

flexsurfer commented Sep 15, 2022

Instructions

Implement the Shell Scan Screen.

Figma: https://www.figma.com/file/eDfxTa9IoaCMUy5cLTp0ys/Shell-for-Mobile?type=design&node-id=451-18994&t=RlXEGOyFRoEJCjEz-0

You should be re-using existing components where available and create components when not.

These are the following details as specified by the design team.

if web or dApp address QR is scanned --> user taken to browser

if a pairing QR is scanned --> user is taken into pairing flow

if a user profile QR is scanned --> user is taken to that user's profile screen

if a community QR is scanned --> user is taken to that community

if a channel in a community QR is scanned --> user is taken to that channel (if they can access it) or to the community home if they can't access that channel

if an ETH address is scanned --> user sees a choice to either send to that address or save that address.  Note if user's client is aware that this address is shared with them via showcase, more metadata can be displayed.

if a WalletConnect QR is scanned --> user enters WalletConnect connect flow

if a user scanner a QR that is non of the above --> an error should be displayed

Communities scanning will work like this:
Screenshot_2023-11-29_at_00 49 21

If this feature grows too large on initial implementation it is fine to notify and only handle 2/3 differrent types of QR codes provided the underlying code easily allows for extending the other features which we can then add in follow up issues.

@ibrkhalil ibrkhalil self-assigned this Sep 15, 2022
@ibrkhalil ibrkhalil removed their assignment May 2, 2023
teoarjun pushed a commit to teoarjun/status-mobile-forked that referenced this issue Jun 29, 2023
teoarjun pushed a commit to teoarjun/status-mobile-forked that referenced this issue Jun 29, 2023
@jo-mut
Copy link
Contributor

jo-mut commented Jan 23, 2024

@J-Son89 looks like this issue is a duplicate of #17574. @alwx has been actively working on it

@J-Son89
Copy link
Contributor

J-Son89 commented Jan 23, 2024

Let's align with @alwx as good to share what we found so far anyway 👍

@jo-mut
Copy link
Contributor

jo-mut commented Jan 23, 2024

@J-Son89 @alwx I will just create a draft pr on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment