Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new profile link format and remove the old one for the "Add a new contact" field #17725

Closed
qoqobolo opened this issue Oct 23, 2023 · 4 comments · Fixed by #17721
Assignees
Labels
deep-link https://www.notion.so/Chainmakers-b78f651f5aa04539ad4ac2a93218d1a7 feature feature requests

Comments

@qoqobolo
Copy link
Contributor

Bug Report

Problem

Follow-up of #17480 @yqrashawn

We should not support the old user profile format like https://status.app/u/zQ3shrgSaffLisbiqj2brkDK8Le7wpbpbpzriWd8kPUmdYhs1 when adding a contact using a deep link

Expected behavior

Formats that should be supported:

https://status.app/u/G10A4B0JdgwyRww90WXtnP1oNH1ZLQNM0yX0Ja9YyAMjrqSZIYINOHCbFhrnKRAcPGStPxCMJDSZlGCKzmZrJcimHY8BbcXlORrElv_BbQEegnMDPx1g9C5VVNl0fE4y#zQ3shwQPhRuDJSjVGVBnTjCdgXy5i9WQaeVPdGJD6yTarJQSj

https://status.app/u/Ow==#zQ3shwQPhRuDJSjVGVBnTjCdgXy5i9WQaeVPdGJD6yTarJQSj

Actual behavior

video_2023-10-23_16-42-20.mp4

Reproduction

  1. Create a profile
  2. Open the chat home screen
  3. Press the + button > Add a contact
  4. Paste the link

Additional Information

  • Status version: nightly 23/10
  • Operating System: Android, iOS
@qoqobolo qoqobolo added bug E:Mobile Release 1.26 deep-link https://www.notion.so/Chainmakers-b78f651f5aa04539ad4ac2a93218d1a7 labels Oct 23, 2023
@qoqobolo qoqobolo added this to the 1.26.0 - Alpha milestone Oct 23, 2023
@qoqobolo
Copy link
Contributor Author

could possibly be combined with an invalid link validation issue #17723

@qoqobolo qoqobolo added feature feature requests and removed bug labels Oct 23, 2023
@cammellos
Copy link
Contributor

@qoqobolo this issue is only to disable the old format? if so I don't think it needs to go in release 1.26, as that's not something that negatively impact the user, what do you think?

@qoqobolo
Copy link
Contributor Author

this issue is only to disable the old format?

@cammellos to disable the old format and add support for the new one for this particular field.

But this would mean that we'd have to develop the ability to generate the new format in the mobile app as well, which is not actually currently in the scope iirc.
But I checked with Rashawn just in case if this part was in the scope, and he said yes, so I added it to 1.26.
However, I agree that it’s better to implement the whole feature of generating a new link format in the mobile app later.
So no objections from my side on postponing this.
cc @yqrashawn

@yqrashawn yqrashawn self-assigned this Oct 25, 2023
@qoqobolo qoqobolo changed the title Remove support for the old profile link format for the "Add a new contact" field Add support for the new profile link format and remove the old one for the "Add a new contact" field Oct 25, 2023
@yqrashawn
Copy link
Contributor

Yes, I already changed the shared profile URL to status.app in the merged PR

although there's no encoded data in it so it's broken

now that I found out we also generate community chat deep link in status-go
I'll just update all places that generate universal/deeplink URL to new format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deep-link https://www.notion.so/Chainmakers-b78f651f5aa04539ad4ac2a93218d1a7 feature feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants