fix(universal-link): more new link format, handle old link format #17721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yqrashawn
force-pushed
the
fix/ulink-change-block-e2e-test
branch
from
1ebc19a to
d74f564
Compare
Jenkins BuildsClick to see older builds (89)
|
|
@yqrashawn thanx for the PR Issue is fixed but only for 1-1 chat. Still reproducing the bug in case of communities and group chats. ISSUE 1 Tapping on community/group chat PN leads to "Browse" popup on AndroidSteps:
Actual result: "Browse" popup is opened telegram-cloud-document-2-5309925075145733258.mp4Expected result: user is redirected to community/group chat |
64% of end-end tests have passedFailed tests (13)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (29)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
@yqrashawn please ping me up for re-test when you'll have a chance to fix the issue. Thank you. |
|
@pavloburykh @yqrashawn is under the weather. Checking it out. I have enabled for group chats, still trying to figure out why |
|
Updates: although there's a conflict between old and new
they have different info in the URL, so I moved the old |
yqrashawn
force-pushed
the
fix/ulink-change-block-e2e-test
branch
from
d74f564 to
03e922e
Compare
Thank you @yqrashawn! So once status-go PR is approved we are ready for re-test, correct? |
|
@pavloburykh also this one, code changed a lot so I dismissed the approved state of this PR. And I just find out the share profile URL is broken as well. I might need to fix it in this PR as well. I'll put this PR into draft state and reevaluate what needs to be done. |
yqrashawn
force-pushed
the
fix/ulink-change-block-e2e-test
branch
2 times, most recently
from
75a64cf to
8a32d46
Compare
@yqrashawn just want to understand what is the difference between https://status.app/cc/Ow==#zQ3shYSHp7GoiXaauJMnDcjwU2yNjdzpXLosAWapPS4CFxc11 AND https://status.app/c/Ow==#zQ3shYSHp7GoiXaauJMnDcjwU2yNjdzpXLosAWapPS4CFxc11 Why do we need those https://status.app/cc/ links if they do not open channel but community? In your file those links are listed within community channel links section |
|
So basically, what happens are
that's why there are both |
|
@yqrashawn are we leaving ISSUE 4 as a followup? |
|
@pavloburykh Yes. I can reproduce it but have some trouble debug it. I'll look into it tomorrow. Can you create an issue for it? |
Sure! I will create a followup once we merge this PR. I am waiting for e2e run and after that will move this PR to merge. |
84% of end-end tests have passedFailed tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (38)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
|
|
@yqrashawn thank you for the PR and all the additional explanations. Ready for merge. |
yqrashawn
force-pushed
the
fix/ulink-change-block-e2e-test
branch
from
32689af to
503178b
Compare
blocking e2e test Signed-off-by: yqrashawn <namy.19@gmail.com>
status-im/status-go@3326362...678fc03 Signed-off-by: yqrashawn <namy.19@gmail.com>
yqrashawn
force-pushed
the
fix/ulink-change-block-e2e-test
branch
from
503178b to
669440e
Compare
|
rebase and update status-go version, waiting for ci |
yqrashawn
changed the title
yevh-berdnyk
pushed a commit
that referenced
this pull request
Dec 8, 2023
…7721) status-im/status-go@d7e7792...678fc03 Co-authored-by: pavloburykh <pavlo@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/u#<user-chat-key>/c#<community-id>/c/<user-chat-key>to new/c#<user-chat-key>/cc/<community-channel-id>#<community-id>fixes #17718
fixes #17725
fixes #17722
fixes #17723
Testing notes
Platforms
Areas that maybe impacted
anywhere related to old
/u/pubkeylinkanything related to universal/deep link
status: ready