Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom linter for i18n/label translation keywords does not currently lint a lot of usages of utils.i18n/label #17782

Closed
akatov opened this issue Oct 31, 2023 · 1 comment · Fixed by #17788

Comments

@akatov
Copy link
Contributor

akatov commented Oct 31, 2023

#17610 provided custom linting of the keywords passed to utils.i18n/label (to enforce namespacing them with :t/).

There are still instances where these keywords aren't linted:

  • within forms that are marked to be linted as clj-kondo.lint-as/def-catch-all, in particular, within utils.re-frame/defn macros.
  • when the keyword isn't passed to the utils.i18n/label directly, but is e.g. inside an if form.

The 2nd case is harder and probably impossible to solve in general during linting and would require run-time checks instead.

@ilmotta
Copy link
Contributor

ilmotta commented Oct 31, 2023

within forms that are marked to be linted as clj-kondo.lint-as/def-catch-all, in particular, within utils.re-frame/defn macros.

FYI @akatov, recently we officially deprecated the usage of utils.re-frame/defn. For many reasons, one being that code inside it is not linted by clj-kondo. So it's better if we don't invest time on that macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants