Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark utils.re-frame/defn as deprecated #17788

Merged
merged 3 commits into from
Nov 6, 2023
Merged

mark utils.re-frame/defn as deprecated #17788

merged 3 commits into from
Nov 6, 2023

Conversation

akatov
Copy link
Contributor

@akatov akatov commented Nov 1, 2023 •
edited
Loading

fixes #17782

image

@status-im-auto
Copy link
Member

status-im-auto commented Nov 1, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (34)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 52bdc4b #1 2023-11-01 13:38:03 ~6 min android 🤖apk 📲
✔️ 52bdc4b #1 2023-11-01 13:38:28 ~6 min android-e2e 🤖apk 📲
✔️ 52bdc4b #1 2023-11-01 13:39:08 ~7 min ios 📱ipa 📲
❌ 52bdc4b #1 2023-11-01 13:47:30 ~15 min tests 📄log
❌ 129a7ab #3 2023-11-01 14:05:52 ~2 min tests 📄log
✔️ 129a7ab #3 2023-11-01 14:09:03 ~5 min android 🤖apk 📲
✔️ 129a7ab #3 2023-11-01 14:09:04 ~5 min ios 📱ipa 📲
✔️ 129a7ab #3 2023-11-01 14:09:11 ~5 min android-e2e 🤖apk 📲
✔️ 09a2071 #4 2023-11-01 16:01:06 ~6 min android-e2e 🤖apk 📲
✔️ 09a2071 #4 2023-11-01 16:01:32 ~6 min android 🤖apk 📲
✔️ 09a2071 #4 2023-11-01 16:04:28 ~9 min tests 📄log
✔️ 09a2071 #4 2023-11-01 16:05:51 ~10 min ios 📱ipa 📲
✔️ 04a97d0 #5 2023-11-01 18:16:30 ~8 min android-e2e 🤖apk 📲
✔️ 04a97d0 #5 2023-11-01 18:16:40 ~8 min android 🤖apk 📲
✔️ 04a97d0 #5 2023-11-01 18:18:52 ~10 min tests 📄log
✔️ 04a97d0 #5 2023-11-01 18:19:26 ~11 min ios 📱ipa 📲
✔️ a2b2e18 #6 2023-11-02 17:28:36 ~6 min android-e2e 🤖apk 📲
✔️ a2b2e18 #6 2023-11-02 17:28:45 ~6 min android 🤖apk 📲
✔️ a2b2e18 #6 2023-11-02 17:41:01 ~18 min ios 📱ipa 📲
✔️ bc768b9 #7 2023-11-03 20:52:37 ~5 min ios 📱ipa 📲
✔️ bc768b9 #7 2023-11-03 20:55:37 ~8 min android-e2e 🤖apk 📲
✔️ bc768b9 #7 2023-11-03 20:55:54 ~8 min android 🤖apk 📲
✔️ bc768b9 #7 2023-11-03 20:57:28 ~10 min tests 📄log
✔️ 37b517f #8 2023-11-04 14:31:00 ~5 min ios 📱ipa 📲
✔️ 37b517f #8 2023-11-04 14:31:40 ~5 min android-e2e 🤖apk 📲
✔️ 37b517f #8 2023-11-04 14:31:51 ~6 min android 🤖apk 📲
✔️ 37b517f #8 2023-11-04 14:35:05 ~9 min tests 📄log
✔️ 6d9a679 #9 2023-11-04 14:44:22 ~8 min android-e2e 🤖apk 📲
✔️ 6d9a679 #9 2023-11-04 14:44:41 ~8 min android 🤖apk 📲
✔️ 6d9a679 #9 2023-11-04 14:46:30 ~10 min tests 📄log
✔️ 6d9a679 #9 2023-11-04 14:46:39 ~10 min ios 📱ipa 📲
✔️ 55bfea5 #10 2023-11-05 14:47:34 ~5 min ios 📱ipa 📲
✔️ 55bfea5 #10 2023-11-05 14:47:59 ~6 min android-e2e 🤖apk 📲
✔️ 55bfea5 #10 2023-11-05 14:48:09 ~6 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bd75582 #11 2023-11-06 20:59:29 ~5 min ios 📱ipa 📲
✔️ bd75582 #11 2023-11-06 21:00:14 ~5 min android-e2e 🤖apk 📲
✔️ bd75582 #11 2023-11-06 21:00:22 ~6 min android 🤖apk 📲
✔️ bd75582 #11 2023-11-06 21:05:11 ~10 min tests 📄log
✔️ 3fa255d #12 2023-11-06 21:35:33 ~5 min ios 📱ipa 📲
✔️ 3fa255d #12 2023-11-06 21:39:08 ~9 min android-e2e 🤖apk 📲
✔️ 3fa255d #12 2023-11-06 21:39:12 ~9 min android 🤖apk 📲
✔️ 3fa255d #12 2023-11-06 21:40:36 ~10 min tests 📄log

ilmotta
ilmotta approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@akatov akatov force-pushed the mark-rf-defn-as-deprecated branch from 129a7ab to 09a2071 Compare November 1, 2023 15:54
@status-im-auto
Copy link
Member

82% of end-end tests have passed

Total executed tests: 45
Failed tests: 4
Expected to fail tests: 4
Passed tests: 37

IDs of failed tests: 702786,702807,702813,702846 

IDs of expected to fail tests: 702731,702808,702783,702732

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: `Text` is `Delivered`
    Device 1: Looking for a message by text: Hey, admin! 

    critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message Hey, admin! was not received by admin



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813

    Device 1: App to background
    Device 2: Sending message 'emoji' 

    critical/chats/test_1_1_public_chats.py:345: in test_1_1_chat_push_emoji
    chat_2.send_message(emoji.emojize(emoji_message))
../views/chat_view.py:1001: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:897: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Channel did not open by clicking on a notification with the mention for admin
E    Edited message is not shown correctly for the sender
E    Edited message is not shown correctly for the (receiver) admin
E    Channel did not open by clicking on a notification with the mention for the invited member



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846

    ## Signed in successfully!
    Device 1: Looking for a message by text: some_text 

    critical/chats/test_public_chat_browsing.py:81: in test_community_navigate_to_channel_when_relaunch
    self.drivers[0].fail("Not navigated to channel view after reopening app")
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Not navigated to channel view after reopening app



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    2. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:617: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!

    [[Data delivery issue]]

    Device sessions

    Passed tests (37)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    5. test_community_discovery, id: 703503
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_one_image_send_reply, id: 702859
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_markdown_support, id: 702809
    Device sessions

    3. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    @churik
    Copy link
    Member

    churik commented Nov 1, 2023

    I suppose it doesn't require manual testing, in this case @ilmotta it is ready to merge

    @akatov akatov force-pushed the mark-rf-defn-as-deprecated branch from 09a2071 to 04a97d0 Compare November 1, 2023 18:08
    @akatov akatov force-pushed the mark-rf-defn-as-deprecated branch 6 times, most recently from 55bfea5 to bd75582 Compare November 6, 2023 20:54
    @akatov akatov force-pushed the mark-rf-defn-as-deprecated branch from bd75582 to 3fa255d Compare November 6, 2023 21:29
    @ilmotta ilmotta merged commit b47c97a into status-im:develop Nov 6, 2023
    5 checks passed
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @akatov @yevh-berdnyk
    Mark utils.re-frame/defn as deprecated (#17788)
    1077b6f 
    Also suggest to use utils.re-frame/reg-event-fx instead of utils.re-frame/defn
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    Assignees
    No one assigned
    Labels
    external
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    custom linter for i18n/label translation keywords does not currently lint a lot of usages of utils.i18n/label
    6 participants
    @akatov @status-im-auto @churik @ilmotta @J-Son89 @flexsurfer