Skip to content

Commit

Permalink
Mark utils.re-frame/defn as deprecated (#17788)
Browse files Browse the repository at this point in the history
Also suggest to use utils.re-frame/reg-event-fx instead of utils.re-frame/defn
  • Loading branch information
akatov authored Nov 6, 2023
1 parent 4ac7f0b commit b47c97a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions doc/new-guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -467,9 +467,9 @@ Prefer the pure version of `:json-rpc/call` (no callbacks).

### Registering event handlers

Register events with `re-frame.core/reg-event-fx` and follow [re-frame's best
Register events with `utils.re-frame/reg-event-fx` and follow [re-frame's best
practice](https://github.com/day8/re-frame/blob/39adca93673f334dc751ee2d99d340b51a9cc6db/docs/FAQs/BestPractice.md#use-the-fx-effect)
so use only `:db` and `:fx` effects. `rf/merge` is deprecated and should not be
so use only `:db` and `:fx` effects. `utils.re-frame/merge` and `utils.re-frame/defn` are deprecated and should not be
used in the new code in `src/status_im2/`. Don't use
`re-frame.core/reg-event-db`.

Expand Down
4 changes: 3 additions & 1 deletion src/utils/re_frame.clj
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
event keywords under which the function will be registered
- TODO: add suport for `prepost-map?` (don't forget to add it to arglist)
- TODO: add validation of macro parameters"
{:arglists '([name doc-string? attr-map? [params*] body])}
{:arglists '([name doc-string? attr-map? [params*] body])
:deprecated true
:superseded-by "utils.re-frame/reg-event-fx"}
[name & fdecl]
(let [m (if (string? (first fdecl))
{:doc (first fdecl)}
Expand Down

0 comments on commit b47c97a

Please sign in to comment.