Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet - Add watch only account flow - Implement Address Validation #17809

Open
J-Son89 opened this issue Nov 3, 2023 · 1 comment
Open

Wallet - Add watch only account flow - Implement Address Validation #17809

J-Son89 opened this issue Nov 3, 2023 · 1 comment
Labels
feature feature requests mobile-core wallet: Create account all issues for the create account page of the wallet

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Nov 3, 2023

On the watch only flows validation is needed to ensure the user puts in a valid address.

Add this validation.

Acceptance Criteria -

  • abstract this validation to the right scope as there is many places in the wallet flows where address validation is required.
  • include unit testing where necessary.
@J-Son89 J-Son89 added the feature feature requests label Nov 3, 2023
@J-Son89 J-Son89 added the wallet: Create account all issues for the create account page of the wallet label Nov 3, 2023
@J-Son89 J-Son89 mentioned this issue Nov 3, 2023
Merged
@smohamedjavid smohamedjavid mentioned this issue Nov 10, 2023
Closed
@Horupa-Olena
Copy link

Horupa-Olena commented Jul 3, 2024 •
edited
Loading

@J-Son89 Hi! Please let me know if this issue is still relevant. Or can we close it?
I see that the feature has already been implemented and validation is working. Is there anything else within the scope of this feature request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature feature requests mobile-core wallet: Create account all issues for the create account page of the wallet
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Status: No status
Status Desktop/Mobile Board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ilmotta @J-Son89 @Horupa-Olena