Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests are not running #17895

Closed
ilmotta opened this issue Nov 13, 2023 · 0 comments · Fixed by #17900
Closed

Integration tests are not running #17895

ilmotta opened this issue Nov 13, 2023 · 0 comments · Fixed by #17900
Assignees

Comments

@ilmotta
Copy link
Contributor

ilmotta commented Nov 13, 2023

Problem

We recently merged #17762, but we missed the fact that the integration tests are not running anymore.

In shadow-cljs, the regular expression looking for test namespaces expect them to end with -test$ by default, but the code we merged don't respect this convention.

Notes

We should probably allow each integration test namespace to run in isolation, thus status_im2/integration_test/core.cljs should not require other integration test namespaces.

@ilmotta ilmotta self-assigned this Nov 13, 2023
ilmotta added a commit that referenced this issue Nov 15, 2023
Integration tests weren't running since #17762 was merged a week ago.

This commit also allows individual integration test namespaces to run if you change the :ns-regexp option in shadow-cljs. This is quite handy, since they are relatively slow.

Fixes #17895
yevh-berdnyk pushed a commit that referenced this issue Dec 8, 2023
Integration tests weren't running since #17762 was merged a week ago.

This commit also allows individual integration test namespaces to run if you change the :ns-regexp option in shadow-cljs. This is quite handy, since they are relatively slow.

Fixes #17895
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant