Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet: Improve emoji screen gesture/scrolling performance #17964

Closed
OmarBasem opened this issue Nov 22, 2023 · 2 comments · Fixed by #18213
Closed

Wallet: Improve emoji screen gesture/scrolling performance #17964

OmarBasem opened this issue Nov 22, 2023 · 2 comments · Fixed by #18213
Assignees
@ulisesmac
Labels
feature feature requests

Comments

@OmarBasem
Copy link
Contributor

OmarBasem commented Nov 22, 2023 •
edited
Loading

A follow up of: #17891

The emoji screen experiences some lagging when scrolling fast, or when scrolling and then trying to swipe down the screen with a gesture.
@OmarBasem OmarBasem mentioned this issue Nov 22, 2023
Merged
@OmarBasem OmarBasem changed the title Wallet: Improve emoji screen performance Wallet: Improve emoji screen gesture/scrolling performance Nov 22, 2023
@ulisesmac
Copy link
Contributor

I'd like to take this issue, @OmarBasem are you planning or working on it?

I'd start it within some days since I'm still busy with other more relevant issues rn.

@OmarBasem
Copy link
Contributor Author

@ulisesmac sure you can take it. But please wait for #17891 to be merged first.

@ulisesmac ulisesmac self-assigned this Dec 14, 2023
@ulisesmac ulisesmac mentioned this issue Dec 16, 2023
Merged
ulisesmac added a commit that referenced this issue Dec 21, 2023
@ulisesmac
[#17964] emoji screen performance (#18213)
5fa9c0c 
* Fix `->` style in emoji-picker.data

* Make `temp-empty-symbol` component code safer to avoid app crashing

* fix `->` style in `emoji-picker.utils`

* Pass sheet-animating? ratom to bottom-sheet's content component

* Improve emoji picker performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulisesmac ulisesmac

Labels
feature feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#17964] emoji screen performance status-im/status-mobile
2 participants
@OmarBasem @ulisesmac