Upgrade nixpkgs to release `23.11` #18311

siddarthkay · 2023-12-28T06:26:58Z

A nixpkgs upgrade is available 23.11 -> https://github.com/NixOS/nixpkgs/releases/tag/23.11

This solves our requirement to upgrade golang beyond 1.20

changes form our existing 23.05 -> NixOS/nixpkgs@23.05...23.11

The text was updated successfully, but these errors were encountered:

siddarthkay · 2023-12-28T06:30:31Z

first challenge I faced when building with 23.11 is with zprint 1.2.8

------------------------------------------------------------------------------------------------------------------------
Produced artifacts:
 /private/tmp/nix-build-zprint-1.2.8.drv-0/zprint (executable)
========================================================================================================================
Finished generating 'zprint' in 5m 51s.
buildPhase completed in 5 minutes 54 seconds
installing
post-installation fixup
checking for references to /private/tmp/nix-build-zprint-1.2.8.drv-0/ in /
nix/store/32l504qgj32mh1yxwmgs9qsz2wdykvvl-zprint-1.2.8...
patching script interpreter paths in /nix/store/32l504qgj32mh1yxwmgs9qsz2wdykvvl-zprint-1.2.8
stripping (with command strip and flags -S) in  
/nix/store/32l504qgj32mh1yxwmgs9qsz2wdykvvl-zprint-1.2.8/bin
error: output '/nix/store/32l504qgj32mh1yxwmgs9qsz2wdykvvl-zprint-1.2.8' is not allowed to refer 
to the following paths:
/nix/store/gy4xl9nhyyc17fsxjqnq4inyncwbqcv8-graalvm-ce-21.0.1
error: build of '/nix/store/1gng5my9ipv4yghm4y16chna3bz9chkf-zprint-1.2.8.drv',
'/nix/store/ngkg5qa2702a4vcc9axj606gww190p8m-clj-kondo-2023.09.07.drv',
'/nix/store/zrbjql28c6rsiv2z8jsba3l07pm9a8gb-clojure-lsp-2023.08.06-00.28.06.drv' 
 failed

maybe @yqrashawn can help?

siddarthkay · 2023-12-29T08:37:52Z

This issue is potentially related to java being bumped up to 21 in this nixpkgs release...

yqrashawn · 2024-01-02T06:14:41Z

It's fixed here NixOS/nixpkgs#269479
But not in 23.1.1
Can we use master? Or it's too unstable?

siddarthkay · 2024-01-02T07:00:33Z

Nice, thanks for the reference @yqrashawn : I too was trying to remove those references manually.
But I can try using the commit mentioned in this PR :)

siddarthkay · 2024-01-02T07:55:00Z

That error is fixed now the next challenge is building go-mobile for android
stacktrace below

error: builder for '/nix/store/hmv9pf8szjdpw34nhybim221zrr0vvia-status-go-0.171.39-debfe1c-android.drv' 
failed with exit code 1;
       last 10 log lines:
       > building
       >
       > Building status-go for: android/arm64
       > /nix/store/cpm4xfas3c0s5zl0k70wsybl4a39llz7-gomobile-unstable-2022-05-18/bin/gomobile: 
       /nix/store/cpm4xfas3c0s5zl0k70wsybl4a39llz7-gomobile-unstable-2022-05-18/bin/gobind -lang=go,java 
       -outdir=/private/tmp/nix-build-status-go-0.171.39-debfe1c-android.drv-0/gomobile-work -tags=
       gowaku_skip_migrations,gowaku_no_rln github.com/status-im/status-go/mobile failed: exit status 1
       > unable to import bind/java: [-: # golang.org/x/mobile/bind/java
       > go/src/golang.org/x/mobile/bind/java/context_android.go:9:10: fatal error: 'jni.h' file not found
       > #include <jni.h>
       >          ^~~~~~~
       > 1 error generated.]
       >
       For full logs, run 
       'nix log /nix/store/hmv9pf8szjdpw34nhybim221zrr0vvia-status-go-0.171.39-debfe1c-android.drv'.
error: build of '/nix/store/9d6c6zba0dwva2r6xj86zc4hlzxy3zcf-watchman-4.9.0.drv',
 '/nix/store/hmv9pf8szjdpw34nhybim221zrr0vvia-status-go-0.171.39-debfe1c-android.drv', 
 '/nix/store/nam12rxlzaiwgnkr2cr55cg1lw73khsj-status-mobile-node-deps-1.25.0-patched.drv' failed
make: *** [run-android] Error 1

jakubgs · 2024-01-02T12:57:55Z

Can we use master? Or it's too unstable?

@yqrashawn I would avoid using master as indeed it is unstable. Either we should wait for the fix to go into nixos-23.11 or we have to fork nixos-23.11 and apply the fix there.

siddarthkay · 2024-01-14T11:26:51Z

That error is fixed now the next challenge is building go-mobile for android stacktrace below

error: builder for '/nix/store/hmv9pf8szjdpw34nhybim221zrr0vvia-status-go-0.171.39-debfe1c-android.drv' 
failed with exit code 1;
       last 10 log lines:
       > building
       >
       > Building status-go for: android/arm64
       > /nix/store/cpm4xfas3c0s5zl0k70wsybl4a39llz7-gomobile-unstable-2022-05-18/bin/gomobile: 
       /nix/store/cpm4xfas3c0s5zl0k70wsybl4a39llz7-gomobile-unstable-2022-05-18/bin/gobind -lang=go,java 
       -outdir=/private/tmp/nix-build-status-go-0.171.39-debfe1c-android.drv-0/gomobile-work -tags=
       gowaku_skip_migrations,gowaku_no_rln github.com/status-im/status-go/mobile failed: exit status 1
       > unable to import bind/java: [-: # golang.org/x/mobile/bind/java
       > go/src/golang.org/x/mobile/bind/java/context_android.go:9:10: fatal error: 'jni.h' file not found
       > #include <jni.h>
       >          ^~~~~~~
       > 1 error generated.]
       >
       For full logs, run 
       'nix log /nix/store/hmv9pf8szjdpw34nhybim221zrr0vvia-status-go-0.171.39-debfe1c-android.drv'.
error: build of '/nix/store/9d6c6zba0dwva2r6xj86zc4hlzxy3zcf-watchman-4.9.0.drv',
 '/nix/store/hmv9pf8szjdpw34nhybim221zrr0vvia-status-go-0.171.39-debfe1c-android.drv', 
 '/nix/store/nam12rxlzaiwgnkr2cr55cg1lw73khsj-status-mobile-node-deps-1.25.0-patched.drv' failed
make: *** [run-android] Error 1

This was an issue with gomobile and was fixed by upgrading go to 1.20 and using this commit as a patch : golang/mobile@406ed3a

siddarthkay · 2024-03-22T16:27:38Z

new issues yay :

iOS build fails on CI with :

[2024-03-22T16:10:36.477Z] [StatusImPR] Processing Info.plist
[2024-03-22T16:10:36.477Z] [StatusImPR] Running script Bundle React Native code and images
[2024-03-22T16:10:36.477Z] ** ARCHIVE FAILED **
[2024-03-22T16:10:36.477Z] 
[2024-03-22T16:10:36.477Z] 
[2024-03-22T16:10:36.477Z] The following build commands failed:
[2024-03-22T16:10:36.478Z] 	PhaseScriptExecution Bundle\ React\ Native\ code\ and\ images /Users/jenkins/
Library/Developer/Xcode/DerivedData/StatusIm-duvifmrkbphbxndmvvwbjhurkcbx/Build/
Intermediates.noindex/ArchiveIntermediates/StatusImPR/IntermediateBuildFilesPath/StatusIm.build/
Release-iphoneos/StatusImPR.build/Script-3AAD2AD524A3A60E0075D594.sh 
(in target 'StatusImPR' from project 'StatusIm')
[2024-03-22T16:10:36.478Z] (1 failure)
[2024-03-22T16:10:36.478Z] [StatusImPR] Generating Status\ PR.app.dSYM
[2024-03-22T16:10:36.478Z] [18:10:35]: Exit status: 65

siddarthkay · 2024-03-22T16:36:39Z

second issue locally when running make shell TARGET=ios is :

error: builder for '/nix/store/y9mrh8y22ggnj1j7l1pxnq1cxamrbwpq-xcode-wrapper-plus-15.0.drv' 
failed with exit code 141

and when trying to inspect the derivation i get :

[nix-shell:/nix/store]$ nix derivation show yng7zcgghnwyharghq09rncg74hwi2yd-xcode-wrapper-15.0.drv
path '/nix/store/yng7zcgghnwyharghq09rncg74hwi2yd-xcode-wrapper-15.0.drv' 
does not contain a 'flake.nix', searching up
error: could not find a flake.nix file

fixes #18311 This PR upgrades `nixpkgs` to latest release version of 23-11 ref -> https://github.com/NixOS/nixpkgs/releases/tag/23.11 - `Gradle` from `8.0.1` -> `8.4` - `Golang` from `1.19` -> `1.20` - `Git` from `2.40.1` -> `2.42.0` - `Curl` from `8.0.1` -> `8.4.0` - `OpenSSL` from `3.0.8` -> `3.0.13` - `NodeJS` from `18.16.0` -> `18.19.1` - `Python` from `3.10.11` -> `3.10.13` - `Clojure` from `1.11.1.1273` -> `1.11.1.1413` - and some more stuff - `xcbeautify` , this was added in 23-11 ->NixOS/nixpkgs#289446 - `idb-companion`, this was also added in 23-11 -> NixOS/nixpkgs#296440

fixes #18311 This PR upgrades `nixpkgs` to latest release version of 23-11 ref -> https://github.com/NixOS/nixpkgs/releases/tag/23.11 - `Gradle` from `8.0.1` -> `8.4` - `Git` from `2.40.1` -> `2.42.0` - `Curl` from `8.0.1` -> `8.4.0` - `OpenSSL` from `3.0.8` -> `3.0.13` - `NodeJS` from `18.16.0` -> `18.19.1` - `Python` from `3.10.11` -> `3.10.13` - `Clojure` from `1.11.1.1273` -> `1.11.1.1413` - and some more stuff - `xcbeautify` , this was added in 23-11 ->NixOS/nixpkgs#289446 - `idb-companion`, this was also added in 23-11 -> NixOS/nixpkgs#296440

siddarthkay added the infra label Dec 28, 2023

siddarthkay changed the title ~~Upgrade nixpkgs to release 23.11~~ Upgrade nixpkgs to release 23.11 Dec 28, 2023

This was referenced Dec 28, 2023

Upgrade react-native to 0.73.x #18291

Closed

nixpkgs upgrade to 23.11 #18321

Closed

siddarthkay linked a pull request Dec 29, 2023 that will close this issue

nixpkgs upgrade to 23.11 #18321

Closed

5 tasks

siddarthkay self-assigned this Jan 15, 2024

siddarthkay mentioned this issue Mar 22, 2024

upgrade nixpkgs to 23-11 #19369

Merged

siddarthkay closed this as completed Mar 22, 2024

siddarthkay reopened this Mar 22, 2024

siddarthkay closed this as completed in #19369 Apr 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade nixpkgs to release `23.11` #18311

Upgrade nixpkgs to release `23.11` #18311

siddarthkay commented Dec 28, 2023 •

edited

Loading

siddarthkay commented Dec 28, 2023 •

edited

Loading

siddarthkay commented Dec 29, 2023

yqrashawn commented Jan 2, 2024

siddarthkay commented Jan 2, 2024

siddarthkay commented Jan 2, 2024

jakubgs commented Jan 2, 2024

siddarthkay commented Jan 14, 2024

siddarthkay commented Mar 22, 2024

siddarthkay commented Mar 22, 2024

Upgrade nixpkgs to release 23.11 #18311

Upgrade nixpkgs to release 23.11 #18311

Comments

siddarthkay commented Dec 28, 2023 • edited Loading

siddarthkay commented Dec 28, 2023 • edited Loading

siddarthkay commented Dec 29, 2023

yqrashawn commented Jan 2, 2024

siddarthkay commented Jan 2, 2024

siddarthkay commented Jan 2, 2024

jakubgs commented Jan 2, 2024

siddarthkay commented Jan 14, 2024

siddarthkay commented Mar 22, 2024

siddarthkay commented Mar 22, 2024

Upgrade nixpkgs to release `23.11` #18311

Upgrade nixpkgs to release `23.11` #18311

siddarthkay commented Dec 28, 2023 •

edited

Loading

siddarthkay commented Dec 28, 2023 •

edited

Loading