Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet - Add malli spec to Quo Wallet components (batch 1) #18354

Closed
Tracked by #18586
J-Son89 opened this issue Jan 2, 2024 · 0 comments · Fixed by #18707
Closed
Tracked by #18586

Wallet - Add malli spec to Quo Wallet components (batch 1) #18354

J-Son89 opened this issue Jan 2, 2024 · 0 comments · Fixed by #18707
Assignees
@mmilad75
Labels
feature feature requests malli Malli schemas

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Jan 2, 2024 •
edited
Loading

To stabilise the wallet project we want to add malli specs to some of the more important/frequently used UI components in the wallet flows.

Add a Malli spec for the following components ->

Quo / Wallet

  • account-card
  • account-origin
  • account-overview
  • account-permissions
  • address-text
  • confirmation-progress

For more info see this pr: #17867

Some examples can be found already in the codebase by searching for uses of namespace schema.core

ping @yqrashawn, @clauxx or @ilmotta if any help is needed when writing these specs.
@J-Son89 J-Son89 changed the title Wallet - Add malli spec to Quo - wallet account-card component Wallet - Add malli spec to Quo Wallet components (batch 1) Jan 2, 2024
@J-Son89 J-Son89 mentioned this issue Jan 22, 2024
Closed
4 tasks
@mmilad75 mmilad75 self-assigned this Jan 30, 2024
@mmilad75 mmilad75 mentioned this issue Feb 2, 2024
Merged
@ilmotta ilmotta added the malli Malli schemas label Feb 5, 2024
mmilad75 added a commit that referenced this issue Feb 8, 2024
@mmilad75
Wallet - Add malli spec to Quo Wallet components (batch 1) #18354 (#1…
523a580 
…8707)

* draft

* add account_card

* add account-origin

* add account_overview

* add account_permission

* add address_text

* add confirmation_progress

* wrapping up

* resolve comments and fix ci issues

* fix ci issues

* fix transaction_progress tests

* fix all tests

* fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmilad75 mmilad75

Labels
feature feature requests malli Malli schemas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wallet - Add malli spec to Quo Wallet components (batch 1) #18354 status-im/status-mobile
3 participants
@ilmotta @J-Son89 @mmilad75