Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to rename key-pair from wallet settings #19917

Closed
Tracked by #19936
seanstrom opened this issue May 6, 2024 · 0 comments · Fixed by #19939
Closed
Tracked by #19936

Allow users to rename key-pair from wallet settings #19917

seanstrom opened this issue May 6, 2024 · 0 comments · Fixed by #19939
Assignees
Labels
wallet: Settings All issues for the mobile wallet settings
Milestone

Comments

@seanstrom
Copy link
Member

Feature Issue

User Story

As a user,
I want edit the name of a key-pair while inside the wallet settings.

Description

Implement the edit feature for key-pair names inside wallet settings.

Designs

Figma flow: the Figma designs

Notes

  • Based on the designs here, the user should not be allowed to rename the default key-pair.

Acceptance Criteria

Screen Description Acceptance Criteria
Key-pair Actions Menu Users can choose to rename a key-pair with actions menu A user should be able to navigate to the name edit screens for a key-pair.
Key-pair Name Edit Users can rename a key-pair with the edit screen A user should be able to edit the name of a key-pair. And the key-pair name edit form should only allow saving if the name has been changed
Key-pair Name Exists Users cannot rename a key-pair with an existing key-pair name The key-pair name edit form should prevent the user from renaming a key-pair with an existing name
Key-pair Name Too Long Users cannot rename a key-pair with too long of a name The key-pair name edit form should prevent the user from renaming a key-pair with too long of a name
Key-pair Name Special Characters Users cannot rename a key-pair with special characters The key-pair name edit form should prevent the user from renaming a key-pair with special characters
Key-pair Name Emojis Users cannot rename a key-pair with emojis The key-pair name edit form should prevent the user from renaming a key-pair with emojis
Key-pair Name Valid Users can rename a key-pair with a valid name The key-pair name edit form should allow the user to rename a key-pair with a valid name
Key-pair Renamed Toast A toast will appear to confirm a key-pair has been renamed The user should see a toast that confirms a key-pair has been renamed
Key-pair Renamed Users can see the renamed key-pair in the key-pair and accounts list The user should see the confirmation toast disappear and should see the renamed key-pair
@seanstrom seanstrom added the wallet: Settings All issues for the mobile wallet settings label May 6, 2024
@mohsen-ghafouri mohsen-ghafouri self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wallet: Settings All issues for the mobile wallet settings
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants