Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is not redirected to external browser when trying to open invalid Status link (Android) #20951

Closed
pavloburykh opened this issue Aug 2, 2024 · 18 comments
Labels
Milestone

Comments

@pavloburykh
Copy link
Contributor

pavloburykh commented Aug 2, 2024

Reproducing on Android only (Samsung Galaxy A52, Android 12).

Example of invalid Status link https://status.app/u/0x04fbce10971e1cd7253b98c7b7e54de3729ca57ce41a2bfb0d1c4e0a26f72c4b6913c3487fa1b4bb86125770f1743fb4459da05c

Steps:

  1. Post given link 1-1 chat/group/comm channel
  2. Tap on the link
  3. Tap Open in Android
  4. See if user is redirected to external browser

Expected result: user should be redirected to external browser

Actual result: user is not redirected to external browser. Browse pop up keeps re-opening.

telegram-cloud-document-2-5289865086792389320.mp4

Additional Information

  • Status version: release 2.30
  • Operating System: Android
@Parveshdhull
Copy link
Member

hi @pavloburykh, Thank you very much for reporting this issue. I tried the above steps, but unfortunately, I cannot reproduce it.

  1. Please can you confirm, that you have other browser applications on your device?
  2. Other apps can launch the browser without any issue? For example link press in the notes app etc.
  3. Is the cancel button working fine and able to break this loop?

@Parveshdhull
Copy link
Member

Parveshdhull commented Aug 5, 2024

Also just to be sure, please can you try removing and reinstalling the app. Maybe status is default browser etc. and launching itself on pressing "Open in Android"

@Parveshdhull
Copy link
Member

hi @churik @qoqobolo, can you please check if you can reproduce this issue?

If it's device-specific and not easily reproducible, should we move this to the next milestone?

@pavloburykh
Copy link
Contributor Author

pavloburykh commented Aug 6, 2024

hi @pavloburykh, Thank you very much for reporting this issue. I tried the above steps, but unfortunately, I cannot reproduce it.

Hi @Parveshdhull! Thank you for looking at the issue.

  1. Please can you confirm, that you have other browser applications on your device?

yes

  1. Other apps can launch the browser without any issue? For example link press in the notes app etc.

yes

  1. Is the cancel button working fine and able to break this loop?

yes

@Parveshdhull just to make sure: which link are you trying to open? Current issue is about invalid Status links. Like the one I have left in the description https://status.app/u/0x04fbce10971e1cd7253b98c7b7e54de3729ca57ce41a2bfb0d1c4e0a26f72c4b6913c3487fa1b4bb86125770f1743fb4459da05c

Other links work fine, user is successfully redirected to external browser.

@pavloburykh
Copy link
Contributor Author

hi @churik @qoqobolo, can you please check if you can reproduce this issue?

If it's device-specific and not easily reproducible, should we move this to the next milestone?

As far as I know @churik is reproducing this issue as well.

@Parveshdhull
Copy link
Member

hi, @pavloburykh,

Thank you very much for confirming. Please can you try these steps and check if this fixes the issue.

output-2024-08-06_15.15.06.mp4

@pavloburykh
Copy link
Contributor Author

hi, @pavloburykh,

Thank you very much for confirming. Please can you try these steps and check if this fixes the issue.

@Parveshdhull I am not sure how to reproduce your steps on physical device using release build. I do not have options to select where to open current link. Also, there is no option "Open in Status" which you have in Debug build. We have removed this option as we have hidden Status browser.

telegram-cloud-document-2-5301298422878327428.mp4

@flexsurfer
Copy link
Member

i'm wondering how this link is different from others that work, it is also a valid link because the page is opened, user id is invalid but it's only related to the status page, not browser

@flexsurfer
Copy link
Member

so most likely there is a loop, statusapp->browser->universal link->status app, but why it works only for invalid id idk

@pavloburykh
Copy link
Contributor Author

i'm wondering how this link is different from others that work, it is also a valid link because the page is opened, user id is invalid but it's only related to the status page, not browser

BTW, we had a similar issue some time ago related to Status browser #17869 which was fixed by #18020

@Parveshdhull
Copy link
Member

image

I think we are in the loop because of this setting. Our intent for using the system browser is working fine, it's just that due to this setting, that intent is relaunching the app.
(For testing purposes, please disable this and see if the browser opens fine. This way we will know at least our browser launch code is working)

@Parveshdhull
Copy link
Member

i'm wondering how this link is different from others that work, it is also a valid link because the page is opened, user id is invalid but it's only related to the status page, not browser

I think even if we try to open valid status link from this device from notes etc, it will always launch status not browser. @pavloburykh please can you confirm.

From notes app, simple link google etc, should launch browser but valid or not all status links should launch app.

@Parveshdhull
Copy link
Member

so most likely there is a loop, statusapp->browser->universal link->status app, but why it works only for invalid id idk

If we click valid link in status app(not other app like notes), then we use app navigation and go to that screen.
In case of invalid we launch browser.

@pavloburykh
Copy link
Contributor Author

(For testing purposes, please disable this and see if the browser opens fine. This way we will know at least our browser launch code is working)

Confirming that browser opens fine when "Open supported links" option is disabled.

I think even if we try to open valid status link from this device from notes etc, it will always launch status not browser. @pavloburykh please can you confirm.

Confirming. This is expected behaviour.

@Parveshdhull
Copy link
Member

https://www.reddit.com/r/Android/comments/qrxsh7/guide_how_to_fix_horrible_handling_of_links_on/?rdt=58840

  1. You can't allow multiple apps to handle the same link (if it was approved manually by you, at least), which means that you can't choose from a list of supported apps when you open a link.

@Parveshdhull
Copy link
Member

Removing my assignment, as this doesn't seem like a fixable bug and seems drawback of Android 12 itself. (Either we allow all status links to be processed by the app or none)

@Parveshdhull Parveshdhull removed their assignment Aug 6, 2024
@pavloburykh
Copy link
Contributor Author

Removing my assignment, as this doesn't seem like a fixable bug and seems drawback of Android 12 itself. (Either we allow all status links to be processed by the app or none)

thank you for your investigation @Parveshdhull

@churik
Copy link
Member

churik commented Aug 7, 2024

Thank you, REmoved it from milestone

@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

5 participants