fix: universal link regex #18020
Merged
fix: universal link regex #18020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (101)
|
yqrashawn
force-pushed
the
fix/universal-link-regex
branch
2 times, most recently
from
1c994b8 to
b957d94
Compare
alwx
approved these changes
Nov 30, 2023
yqrashawn
force-pushed
the
fix/universal-link-regex
branch
from
b957d94 to
73249f5
Compare
BalogunofAfrica
approved these changes
Dec 1, 2023
71% of end-end tests have passedFailed tests (10)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (34)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
60% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Passed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
|
yqrashawn
force-pushed
the
fix/universal-link-regex
branch
from
73249f5 to
6ee5fac
Compare
85% of end-end tests have passedFailed tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (41)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
|
yqrashawn
force-pushed
the
fix/universal-link-regex
branch
from
6ee5fac to
1af6ed2
Compare
|
rebased onto dev |
|
Hi @yqrashawn , thanks for the fix! Q1: Nothing happens when you click on an invalid link if you add extra characters to the key (to make it invalid)watch the video please: IMG_1869.MP4
Q2: could you give me a clue on testing notes? :)
What should I pay attention to besides, for example, scanning such links in the new wallet? |
yqrashawn
force-pushed
the
fix/universal-link-regex
branch
2 times, most recently
from
91078e2 to
81f12b9
Compare
|
Q1: fixed now |
|
Thanks @yqrashawn ISSUE 1: Some link formats no longer trigger app launch on AndroidWhen you click the following links in an external messenger you get 404 on web or https://status.app/u#zQ3shwQPhRuDJSjVGVBnTjCdgXy5i9WQaeVPdGJD6yTarJQSj PR video_2023-12-06_13-24-02.mp4video_2023-12-06_13-24-30.mp4Nightly video_2023-12-06_13-24-55.mp4Links of this format also work fine: https://status.app/u/G10A4B0JdgwyRww90WXtnP1oNH1ZLQNM0yX0Ja9YyAMjrqSZIYINOHCbFhrnKRAcPGStPxCMJDSZlGCKzmZrJcimHY8BbcXlORrElv_BbQEegnMDPx1g9C5VVNl0fE4y#zQ3shwQPhRuDJSjVGVBnTjCdgXy5i9WQaeVPdGJD6yTarJQSj And all the formats redirect you to the right place if they are posted inside the app in a chat. Steps to reproduce:
|
79% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (6)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (38)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
Q3: Why if I add extra characters to the
|
yqrashawn
force-pushed
the
fix/universal-link-regex
branch
2 times, most recently
from
b98e8df to
4cf7f69
Compare
|
ISSUE 3 should be fixed now @qoqobolo |
81% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (39)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
|
|
@yqrashawn thank you for the fix! ISSUE 4: Community link (
|
yqrashawn
force-pushed
the
fix/universal-link-regex
branch
3 times, most recently
from
922b49c to
8316ec1
Compare
|
@qoqobolo ISSUE 4 should be fixed now |
69% of end-end tests have passedFailed tests (11)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (33)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
|
73% of end-end tests have passedFailed tests (3)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Passed tests (8)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
|
yqrashawn
force-pushed
the
fix/universal-link-regex
branch
2 times, most recently
from
652b047 to
8fbaaea
Compare
0% of end-end tests have passedFailed tests (2)Click to expandClass TestDeepLinksOneDevice:
|
50% of end-end tests have passedFailed tests (1)Click to expandClass TestDeepLinksOneDevice:
Passed tests (1)Click to expandClass TestDeepLinksOneDevice:
|
|
@yqrashawn thanks for your work and all the fixes! |
yqrashawn
force-pushed
the
fix/universal-link-regex
branch
from
0fdc70d to
c3e615a
Compare
fixes #17869 Signed-off-by: yqrashawn <namy.19@gmail.com>
yqrashawn
force-pushed
the
fix/universal-link-regex
branch
from
c3e615a to
5737f23
Compare
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17869
Summary
update universal link regex
issue caused by bad universal link regex used when open URL in built-in browser
thus causing this loop
URL -> handle universal-link -> fallback to open in browser -> oh it's universal link -> handler universal-link
Testing notes
affects places using this regex
:wallet-legacy/parse-eip681-uri-and-resolve-ensstatus: ready