Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement chat secondary actions on left panel #5311

Closed
EugeOrtiz opened this issue Jul 26, 2018 · 3 comments
Closed

Implement chat secondary actions on left panel #5311

EugeOrtiz opened this issue Jul 26, 2018 · 3 comments
Assignees

Comments

@EugeOrtiz
Copy link

EugeOrtiz commented Jul 26, 2018

Story
As a user, I want to be able to find secondary actions on 1:1 and public chats when I right-click on the user's row on the left panel.

Actual behaivor
Nothing happens when right clicking on a 1:1 or public chat row on left panel.

Expected behavior
When right clicking on "Super Violet Coordinated" row:
captura de pantalla 2018-07-26 a la s 4 02 01 p m
When right clicking on "#peoplewholovedogs" row:
captura de pantalla 2018-07-26 a la s 4 06 20 p m
Note: This behavior was observed on most of participants during usability test.
Designs (Zeplin) >> zpl.io/V4J4NX4

@churik churik changed the title Implement 1:1 chat secondary actions on left panel Implement chat secondary actions on left panel Aug 15, 2018
@chadyj chadyj removed the desktop label Sep 14, 2018
@chadyj
Copy link
Contributor

chadyj commented Sep 14, 2018

Question.... is this a custom styled menu, or can we use system menu?

@EugeOrtiz
Copy link
Author

I tweaked the style a little bit (more space, highlight based on our color palette). A good-enough V1 could be using native ones.

@yenda
Copy link
Contributor

yenda commented Oct 6, 2018

@alwx you can check for right click in touchable highlight with

[react/touchable-highlight {:on-press #(when (= "right" (.-button (.-nativeEvent %)))
                                            (utils/show-popup "" "Message copied to clipboard")
                                            (react/copy-to-clipboard text))}
 [react/text "hello"]]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants