Add popup menu support for chat header and chat list #6671

vitvly · 2018-11-09T11:50:31Z

Fixes #5311 #5314

ghost · 2018-11-09T11:50:35Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?

rcullito

Nice PR! Included a couple questions inline.

rcullito · 2018-11-09T20:10:24Z

components/src/status_im/ui/components/react.cljs

+(def popup-menu-options (adapt-class (.-MenuOptions js-dependencies/popup-menu)))
+(def popup-menu-option (adapt-class (.-MenuOption js-dependencies/popup-menu)))
+(def popup-menu-trigger (adapt-class (.-MenuTrigger js-dependencies/popup-menu)))
+(def popup-menu-renderers (js->clj (.-renderers js-dependencies/popup-menu) :keywordize-keys true))


I'm lacking context here clearly, but what is the guideline for converting to clj data structure in the last form versus adapt-class in the others? Thank you!

renderers is not a class, but a folder inside react-native-popup-menu. In this case (.-renderers js-dependencies/popup-menu) returns a js object with string keys (map of class names to objects) So we convert it to a Clojure-style keyword map.

great, thanks for clarifying.

rcullito · 2018-11-09T20:15:45Z

src/status_im/ui/screens/desktop/main/tabs/home/views.cljs

+                       {:keys [group-chat public? public-key] :as chat}]]
+  [popup-menu/wrap-with-menu
+   [chat-list-item-inner-view (assoc chat :chat-id chat-id)]
+   (remove nil?


which set of chats are expected to not be removed here? just private, or are we up to additional categories? 👁️

remove affects menu items for this particular chat item, not the chat list. So for public/group chats we cannot execute View Profile, for example. Will write the doc for wrap-with-menu, sorry for confusion.

ah, no that makes total sense. my own confusion for missing at what level the remove was acting upon. thanks!

churik · 2018-11-13T13:42:12Z

@siphiuel can it be tested? If yes, can you please rebase it and move to TO TEST column? Thanks!

vitvly · 2018-11-13T14:23:01Z

Rebased and moved to TO TEST.

status-comment-bot · 2018-11-15T13:52:27Z

✅ CI BUILD SUCCESSFUL

Jenkins job: #8

Mobile

Android, (e2e)
iOS

Desktop

status-comment-bot · 2018-11-15T14:17:39Z

✅ #9 CI BUILD SUCCESSFUL in 25 min and counting (`65a7813`)


Android(e2e)	iOS	MacOS	AppImage	Windows

churik · 2018-11-16T09:24:43Z

@SlizkovaGanna
any blockers here so far? do you need any help?

SlizkovaGanna · 2018-11-16T10:02:50Z

Tested on MacOS and Linux (emulated)

Issues found:

1. The 'Unknown' user it triggered when selecting 'View profile' on right-click from the chat list, reproduces for all contacts every time
Steps to reproduce:

Login to Status and go to your Home screen with at least 1-1 chat with a contact
Right-click on that chat and select 'View profile' from the menu
Expected result: User's profile is shown with 'Add to contacts' being inactive
Current result: 'Unknown' profile is displayed, not from your contacts.
Note: If you add that 'Unknown' to contacts - you will see two people in contact list - the initial contact you had 1-1 chat with at the start, and the 'Unknown'

Click 'Send message' - a new 1-1 chat with the 'Unknown' will appear
Expected result: User is redirected to the already existing 1-1 chat
Current result: A new 1-1 chat with the 'Unknown' will appear

Start typing a message
Expected result: Message input as usual
Current result: With every symbol, 'Unknown''s icon changes to a different default one in the chat list on the left

2. When triggering the right-click menu in the chat list, the menu contains options for the chat that the mouse pointer is at, but performs actions for the chat that is selected at the moment
In some cases, it leads to even crashing the app:

Steps to reproduce:

Create a group chat, 1-1 chat and join a public chat

Select the 1-1 chat, but right-click the group chat area and select 'Group info'
Expected result: Not sure what the expected result it - a menu for the highlighted chat (if so - there should be no 'group info' option) or the chat that the mouse pointer is at (if so - group info of the group chat should be displayed); either way menus should not mix up like they do
Current result: The group info of 1-1 chat is displayed, as if it was a group chat:

Same for a public chat:

Also tested:

view profile/group info (1-1, group), both menus
deleting history (1-1, group, public) and checking it doesn't re-appear, both menus
deleting chats (1-1, group, public) and checking it doesn't re-appear, both menus
messaging (regular, different symbols, offline, fetching messages)

status-comment-bot · 2018-11-29T00:28:12Z

✅ #12 CI BUILD SUCCESSFUL in 21 min and counting (`861e5ab`)


Android(e2e)	iOS	MacOS	AppImage	Windows

status-comment-bot · 2018-11-29T00:49:04Z

✅ #13 CI BUILD SUCCESSFUL in 20 min and counting (`21f1388`)


Android(e2e)	iOS	MacOS	AppImage	Windows

status-comment-bot · 2018-11-29T01:14:33Z

✅ #14 CI BUILD SUCCESSFUL in 25 min and counting (`4bd6a28`)


Android(e2e)	iOS	MacOS	AppImage	Windows

asemiankevich · 2018-11-30T11:53:31Z

@rcullito @Maxris builds are failing in Jenkins, i restarted it not sure about success, please take a look https://ci.status.im/job/status-react/job/pull%20requests/view/change-requests/job/PR-6671/

PR-6671 [status-react » pull requests] [Jenkins]

asemiankevich · 2018-11-30T13:40:35Z

@siphiuel please rebase :)

status-comment-bot · 2018-11-30T17:24:49Z

✅ #22 CI BUILD SUCCESSFUL in 35 min and counting (faa733d5de35e5c5e20008c9e932ed182a5c8f06)


Android(e2e)	iOS	MacOS	AppImage	Windows

statustestbot · 2018-11-30T20:53:57Z

97% of end-end tests have passed

Total executed tests: 59
Failed tests: 2
Passed tests: 57

Failed tests (2)

Click to expand

1. test_user_can_interact_with_public_chat
Device 1: Scrolling down to HistoryTimeMarker Device 1: Looking for an element by text: 'Yesterday' `'Yesterday' chat marker is not shown` Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_network_mismatch_for_send_request_commands
Device 1: Tap on GotItButton Device 1: Looking for a message by text: '0.01130203128' `Device 1: 'ChatElementByText' is not found on the screen` Device sessions Device 2: Steps, video, logs Failure screenshot Device 1: Steps, video, logs Failure screenshot

Passed tests (57)

Click to expand

1. test_create_account
Device sessions Device 1: Steps, video, logs
2. test_user_can_switch_network
Device sessions Device 1: Steps, video, logs
3. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
4. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
5. test_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
6. test_request_and_receive_tokens_in_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_delete_cut_and_paste_messages
Device sessions Device 1: Steps, video, logs
8. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
9. test_offline_login
Device sessions Device 1: Steps, video, logs
10. test_pass_phrase_validation
Device sessions Device 1: Steps, video, logs
11. test_public_chat_messaging
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
12. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
13. test_set_profile_picture
Device sessions Device 1: Steps, video, logs
14. test_text_message_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
15. test_add_to_contacts
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
16. test_unread_messages_counter_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
17. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
18. test_onboarding_screen_when_requesting_tokens_for_new_account
Device sessions Device 1: Steps, video, logs
19. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
20. test_send_token_with_7_decimals
Device sessions Device 1: Steps, video, logs
21. test_modify_transaction_fee_values
Device sessions Device 1: Steps, video, logs
22. test_token_with_more_than_allowed_decimals
Device sessions Device 1: Steps, video, logs
23. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
24. test_send_transaction_details_in_1_1_chat
Device sessions Device 1: Steps, video, logs
25. test_manage_assets
Device sessions Device 1: Steps, video, logs
26. test_wallet_set_up
Device sessions Device 1: Steps, video, logs
27. test_logcat_send_transaction_in_1_1_chat
Device sessions Device 1: Steps, video, logs
28. test_request_and_receive_eth_in_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
29. test_swipe_to_delete_public_chat
Device sessions Device 1: Steps, video, logs
30. test_passphrase_whitespaces_ignored_while_recovering_access
Device sessions Device 1: Steps, video, logs
31. test_send_emoji
Device sessions Device 1: Steps, video, logs
32. test_add_contact_by_pasting_public_key
Device sessions Device 1: Steps, video, logs
33. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
34. test_messaging_in_different_networks
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
35. test_send_tokens_in_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
36. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
37. test_swipe_to_delete_1_1_chat
Device sessions Device 1: Steps, video, logs
38. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
39. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
40. test_send_eth_in_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
41. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
42. test_send_eth_from_wallet_to_contact
Device sessions Device 1: Steps, video, logs
43. test_add_contact_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
44. test_send_request_not_enabled_tokens
Device sessions Device 1: Steps, video, logs
45. test_send_message_to_newly_added_contact
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
46. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
47. test_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
48. test_offline_status
Device sessions Device 1: Steps, video, logs
49. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
50. test_unread_messages_counter_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
51. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
52. test_user_can_remove_profile_picture
Device sessions Device 1: Steps, video, logs
53. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
54. test_request_eth_in_wallet
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
55. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs
56. test_backup_recovery_phrase_warning_from_wallet
Device sessions Device 1: Steps, video, logs
57. test_recover_account
Device sessions Device 1: Steps, video, logs

SlizkovaGanna · 2018-11-30T23:46:35Z

Tested on MacOS and Linux (emulated)

There were no specific PR-related issues found, all the general ones found will be reported separately.
The only things I can possible name is a different design of the pop-up window on Linux

Linux:

MaxOS:

@siphiuel if its possible to fix, I'll create a separate low priority issue for it.

Tested:

The 'Unknown' user it triggered when selecting 'View profile' on right-click from the chat list, reproduces for all contacts every time - fixed

@Serhy Also checked scenarios for 'Unknown' issue from #6210
scenario #1 - waiting for 24 h to pass
scenario #2 - does not reproduce on this build
Would need to recheck the general issue after this PR is merged.

When triggering the right-click menu in the chat list, the menu contains options for the chat that the mouse pointer is at, but performs actions for the chat that is selected at the moment - fixed
view profile/group info (1-1, group), both menus
deleting history (1-1, group, public) and checking it doesn't re-appear, both menus
deleting chats (1-1, group, public) and checking it doesn't re-appear, both menus
messaging (regular, different symbols, offline, fetching messages)
pairing

Automated tests fails are expected.
Tested on MacOs and Linux (emulated)

Signed-off-by: Vitaliy Vlasov <siphiuel@gmail.com>

status-comment-bot · 2018-12-01T00:24:03Z

✅ #23 CI BUILD SUCCESSFUL in 21 min and counting (e7ff692aaaa1ff344edbefcac5090bdfa2074110)


Android(e2e)	iOS	MacOS	AppImage	Windows

vitvly self-assigned this Nov 9, 2018

vitvly added the desktop label Nov 9, 2018

vitvly changed the title ~~[WIP] Add popup menu support for chat header~~ [WIP] Add popup menu support for chat header and chat list Nov 9, 2018

vitvly changed the title ~~[WIP] Add popup menu support for chat header and chat list~~ Add popup menu support for chat header and chat list Nov 9, 2018

vitvly requested review from vkjr, rcullito, yenda and maxhora November 9, 2018 19:59

rcullito approved these changes Nov 9, 2018

View reviewed changes

maxhora approved these changes Nov 9, 2018

View reviewed changes

vkjr approved these changes Nov 12, 2018

View reviewed changes

vitvly force-pushed the feature/add-popup-menu branch from 6420acf to 1b6d18b Compare November 13, 2018 14:21

SlizkovaGanna self-assigned this Nov 15, 2018

vitvly force-pushed the feature/add-popup-menu branch from a473851 to 65a7813 Compare November 15, 2018 13:24

SlizkovaGanna added the Tested - Issues label Nov 16, 2018

SlizkovaGanna removed their assignment Nov 29, 2018

vitvly force-pushed the feature/add-popup-menu branch from 4bd6a28 to 8edfd42 Compare November 29, 2018 20:37

SlizkovaGanna self-assigned this Nov 30, 2018

asemiankevich removed the Tested - Issues label Nov 30, 2018

jakubgs force-pushed the feature/add-popup-menu branch from 8edfd42 to 90c3a5b Compare November 30, 2018 13:42

vitvly force-pushed the feature/add-popup-menu branch 2 times, most recently from 8e8c91d to faa733d Compare November 30, 2018 16:48

SlizkovaGanna added the Tested - OK label Nov 30, 2018

vitvly force-pushed the feature/add-popup-menu branch from faa733d to e7ff692 Compare December 1, 2018 00:02

Add react-native-desktop-menu native module

dc4841f

Signed-off-by: Vitaliy Vlasov <siphiuel@gmail.com>

vitvly force-pushed the feature/add-popup-menu branch from e7ff692 to dc4841f Compare December 1, 2018 00:03

vitvly merged commit dc4841f into develop Dec 1, 2018

chadyj mentioned this pull request Dec 1, 2018

Implement secondary actions on public and 1:1 chat headers #5314

Closed

SlizkovaGanna mentioned this pull request Dec 3, 2018

'Unknown' username on user Profile for contact who received message with no contact-request #6210

Closed

rasom deleted the feature/add-popup-menu branch January 11, 2019 17:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add popup menu support for chat header and chat list #6671

Add popup menu support for chat header and chat list #6671

vitvly commented Nov 9, 2018 •

edited

Loading

ghost commented Nov 9, 2018

rcullito left a comment

rcullito Nov 9, 2018

vitvly Nov 9, 2018

rcullito Nov 9, 2018

rcullito Nov 9, 2018

vitvly Nov 9, 2018

rcullito Nov 9, 2018

churik commented Nov 13, 2018

vitvly commented Nov 13, 2018

status-comment-bot commented Nov 15, 2018

status-comment-bot commented Nov 15, 2018

churik commented Nov 16, 2018

SlizkovaGanna commented Nov 16, 2018 •

edited

Loading

status-comment-bot commented Nov 29, 2018

status-comment-bot commented Nov 29, 2018

status-comment-bot commented Nov 29, 2018

asemiankevich commented Nov 30, 2018 •

edited

Loading

asemiankevich commented Nov 30, 2018

status-comment-bot commented Nov 30, 2018

statustestbot commented Nov 30, 2018

SlizkovaGanna commented Nov 30, 2018

status-comment-bot commented Dec 1, 2018

Add popup menu support for chat header and chat list #6671

Add popup menu support for chat header and chat list #6671

Conversation

vitvly commented Nov 9, 2018 • edited Loading

ghost commented Nov 9, 2018

Pull Request Checklist

rcullito left a comment

Choose a reason for hiding this comment

rcullito Nov 9, 2018

Choose a reason for hiding this comment

vitvly Nov 9, 2018

Choose a reason for hiding this comment

rcullito Nov 9, 2018

Choose a reason for hiding this comment

rcullito Nov 9, 2018

Choose a reason for hiding this comment

vitvly Nov 9, 2018

Choose a reason for hiding this comment

rcullito Nov 9, 2018

Choose a reason for hiding this comment

churik commented Nov 13, 2018

vitvly commented Nov 13, 2018

status-comment-bot commented Nov 15, 2018

✅ CI BUILD SUCCESSFUL

Mobile

Desktop

status-comment-bot commented Nov 15, 2018

✅ #9 CI BUILD SUCCESSFUL in 25 min and counting (65a7813)

churik commented Nov 16, 2018

SlizkovaGanna commented Nov 16, 2018 • edited Loading

status-comment-bot commented Nov 29, 2018

✅ #12 CI BUILD SUCCESSFUL in 21 min and counting (861e5ab)

status-comment-bot commented Nov 29, 2018

✅ #13 CI BUILD SUCCESSFUL in 20 min and counting (21f1388)

status-comment-bot commented Nov 29, 2018

✅ #14 CI BUILD SUCCESSFUL in 25 min and counting (4bd6a28)

asemiankevich commented Nov 30, 2018 • edited Loading

asemiankevich commented Nov 30, 2018

status-comment-bot commented Nov 30, 2018

✅ #22 CI BUILD SUCCESSFUL in 35 min and counting (faa733d5de35e5c5e20008c9e932ed182a5c8f06)

statustestbot commented Nov 30, 2018

97% of end-end tests have passed

Failed tests (2)

Passed tests (57)

SlizkovaGanna commented Nov 30, 2018

status-comment-bot commented Dec 1, 2018

✅ #23 CI BUILD SUCCESSFUL in 21 min and counting (e7ff692aaaa1ff344edbefcac5090bdfa2074110)

vitvly commented Nov 9, 2018 •

edited

Loading

✅ #9 CI BUILD SUCCESSFUL in 25 min and counting (`65a7813`)

SlizkovaGanna commented Nov 16, 2018 •

edited

Loading

✅ #12 CI BUILD SUCCESSFUL in 21 min and counting (`861e5ab`)

✅ #13 CI BUILD SUCCESSFUL in 20 min and counting (`21f1388`)

✅ #14 CI BUILD SUCCESSFUL in 25 min and counting (`4bd6a28`)

asemiankevich commented Nov 30, 2018 •

edited

Loading