Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Sign message from Send transaction flow #7570

Closed
goranjovic opened this issue Feb 25, 2019 · 0 comments · Fixed by #7554
Closed

Decouple Sign message from Send transaction flow #7570

goranjovic opened this issue Feb 25, 2019 · 0 comments · Fixed by #7554
Assignees
@goranjovic

Comments

@goranjovic
Copy link
Contributor

Problem

Large PR with Wallet redesign is not mergeable because of dependencies between Send and Sign message flows

Implementation

Decouple Sign message from Send transaction flow

Acceptance Criteria

  • flows are decoupled
  • Sign message depends on navigation parameters only, not arbitrary (shared) part of app-db.

Future Steps

Scavenge Wallet Redesign PR further - #7263 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goranjovic goranjovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor #7263 - decoupled sign message flow from send transaction flow status-im/status-mobile
1 participant
@goranjovic