Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor #7263 - decoupled sign message flow from send transaction flow #7554

Merged
merged 1 commit into from
Mar 1, 2019
Merged

refactor #7263 - decoupled sign message flow from send transaction flow #7554

merged 1 commit into from
Mar 1, 2019

Conversation

goranjovic
Copy link
Contributor

@goranjovic goranjovic commented Feb 22, 2019 •
edited
Loading

fixes #7570
partially addresses #7263

Problem

Sign message flow was tightly coupled with Send transaction flow, so it was rather difficult to prevent PR scope creep. This PR addresses the issue by decoupling the two flows.

The purpose of this PR is to gradually prepare develop branch for the changes intended in #7263

Review notes:

Two major things introduced here:

  • using view parameters instead of a piece of app-db shared with other parts of the code
  • local state is encapsulated in a locally declared atom

Testing notes (optional):

Sign message and Send transaction should work as before. No behavior changes

status: ready

@status-github-bot
Copy link

status-github-bot bot commented Feb 22, 2019 •
edited by goranjovic
Loading

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@goranjovic goranjovic self-assigned this Feb 22, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Feb 22, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 3a78779 #1 2019-02-22 13:00:47 ~3 min macos 📄 log
✔️ 3a78779 #1 2019-02-22 13:12:03 ~15 min ios-e2e 📦 pkg
✔️ 3a78779 #1 2019-02-22 13:13:11 ~16 min ios 📦 ipa
✔️ 3a78779 #1 2019-02-22 13:14:26 ~17 min android-e2e 📦 apk
✔️ 3a78779 #1 2019-02-22 13:18:33 ~21 min android 📦 apk
✔️ 3a78779 #1 2019-02-22 13:19:31 ~22 min windows 📦 exe
✔️ 3a78779 #1 2019-02-22 13:19:42 ~22 min linux 📦 App
✔️ 8c18b4a #2 2019-02-26 09:45:21 ~17 min android-e2e 📦 apk
✔️ 8c18b4a #2 2019-02-26 09:46:15 ~18 min android 📦 apk
✔️ 8c18b4a #2 2019-02-26 09:46:18 ~18 min ios-e2e 📦 pkg
✔️ 8c18b4a #2 2019-02-26 09:47:47 ~19 min windows 📦 exe
✔️ 8c18b4a #2 2019-02-26 09:49:43 ~21 min linux 📦 App
✔️ 8c18b4a #2 2019-02-26 09:55:15 ~26 min macos 📦 dmg
✔️ 8c18b4a #3 2019-02-27 10:09:00 ~16 min ios 📦 ipa

@goranjovic goranjovic force-pushed the feature/separate-sign-message-7263 branch from 3a78779 to 8c18b4a Compare February 26, 2019 09:28
@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 58
Failed tests: 0
Passed tests: 58

Passed tests (58)

Click to expand
1. test_create_account
Device sessions

2. test_user_can_switch_network
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_request_and_receive_tokens_in_1_1_chat
Device sessions

7. test_delete_cut_and_paste_messages
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_offline_login
Device sessions

10. test_pass_phrase_validation
Device sessions

11. test_public_chat_messaging
Device sessions

12. test_open_chat_by_pasting_public_key
Device sessions

13. test_password_in_logcat_sign_in
Device sessions

14. test_set_profile_picture
Device sessions

15. test_text_message_1_1_chat
Device sessions

16. test_add_to_contacts
Device sessions

17. test_unread_messages_counter_1_1_chat
Device sessions

18. test_logcat_send_transaction_from_daap
Device sessions

19. test_onboarding_screen_when_requesting_tokens_for_new_account
Device sessions

20. test_logcat_send_transaction_from_wallet
Device sessions

21. test_send_token_with_7_decimals
Device sessions

22. test_modify_transaction_fee_values
Device sessions

23. test_token_with_more_than_allowed_decimals
Device sessions

24. test_send_eth_from_wallet_to_address
Device sessions

25. test_send_transaction_details_in_1_1_chat
Device sessions

26. test_manage_assets
Device sessions

27. test_wallet_set_up
Device sessions

28. test_logcat_send_transaction_in_1_1_chat
Device sessions

29. test_request_and_receive_eth_in_1_1_chat
Device sessions

30. test_swipe_to_delete_public_chat
Device sessions

31. test_passphrase_whitespaces_ignored_while_recovering_access
Device sessions

32. test_send_emoji
Device sessions

33. test_logcat_recovering_account
Device sessions

34. test_messaging_in_different_networks
Device sessions

35. test_send_tokens_in_1_1_chat
Device sessions

36. test_network_mismatch_for_send_request_commands
Device sessions

37. test_logcat_sign_message_from_daap
Device sessions

38. test_swipe_to_delete_1_1_chat
Device sessions

39. test_switch_users_and_add_new_account
Device sessions

40. test_send_stt_from_wallet
Device sessions

41. test_send_eth_in_1_1_chat
Device sessions

42. test_login_with_new_account
Device sessions

43. test_send_eth_from_wallet_to_contact
Device sessions

44. test_add_contact_from_public_chat
Device sessions

45. test_send_request_not_enabled_tokens
Device sessions

46. test_send_message_to_newly_added_contact
Device sessions

47. test_password_in_logcat_creating_account
Device sessions

48. test_backup_recovery_phrase
Device sessions

49. test_offline_status
Device sessions

50. test_open_google_com_via_open_dapp
Device sessions

51. test_unread_messages_counter_public_chat
Device sessions

52. test_sign_message_from_daap
Device sessions

53. test_user_can_remove_profile_picture
Device sessions

54. test_share_contact_code_and_wallet_address
Device sessions

55. test_request_eth_in_wallet
Device sessions

56. test_refresh_button_browsing_app_webview
Device sessions

57. test_backup_recovery_phrase_warning_from_wallet
Device sessions

58. test_recover_account
Device sessions

@asemiankevich asemiankevich self-assigned this Feb 26, 2019
@goranjovic @mandrigin
refactor #7263 - decoupled sign message flow from send transaction flow
520f6ad 
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
@mandrigin mandrigin force-pushed the feature/separate-sign-message-7263 branch from 8c18b4a to 520f6ad Compare March 1, 2019 13:41
@mandrigin mandrigin merged commit 520f6ad into develop Mar 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/separate-sign-message-7263 branch March 1, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryn dmitryn dmitryn approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees

@goranjovic goranjovic

@asemiankevich asemiankevich

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decouple Sign message from Send transaction flow
7 participants
@goranjovic @status-im-auto @statustestbot @dmitryn @flexsurfer @mandrigin @asemiankevich