Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Request transaction flow from Send transaction flow #7571

Closed
goranjovic opened this issue Feb 25, 2019 · 0 comments · Fixed by #7583
Closed

Decouple Request transaction flow from Send transaction flow #7571

goranjovic opened this issue Feb 25, 2019 · 0 comments · Fixed by #7583
Assignees
@goranjovic

Comments

@goranjovic
Copy link
Contributor

Problem

Large PR with Wallet redesign is not mergeable because of dependencies between Send and Request transaction flows

Implementation

Decouple Request transaction from Send transaction flow

Acceptance Criteria

  • flows are decoupled
  • Request transaction does not depend on the same part of app-db as Send transaction does. (Refactoring to use navigation parameters only is outside the scope of this task, it only needs to be decoupled from the Send flow)

Future Steps

Scavenge Wallet Redesign PR further - #7263 (comment)
@goranjovic goranjovic self-assigned this Feb 25, 2019
@goranjovic goranjovic changed the title Recouple Request transaction flow from Send transaction flow Decouple Request transaction flow from Send transaction flow Feb 25, 2019
goranjovic added a commit that referenced this issue Feb 26, 2019
@goranjovic
refactor #7571 - decoupled request transaction from send transaction …
d3bc08f 
…flow
@goranjovic goranjovic mentioned this issue Feb 26, 2019
Merged
goranjovic added a commit that referenced this issue Mar 4, 2019
@goranjovic
refactor #7571 - decoupled request transaction from send transaction …
e0cc81d 
…flow
@Serhy Serhy mentioned this issue Mar 11, 2019
Closed
goranjovic added a commit that referenced this issue Mar 13, 2019
@goranjovic
refactor #7571 - decoupled request transaction from send transaction …
ad2f448 
…flow
goranjovic added a commit that referenced this issue Mar 14, 2019
@goranjovic
refactor #7571 - decoupled request transaction from send transaction …
db7bbb1 
…flow
goranjovic added a commit that referenced this issue Mar 15, 2019
@goranjovic
refactor #7571 - decoupled request transaction from send transaction …
fcb3cef 
…flow

Signed-off-by: Goran Jovic <goranjovic@gmail.com>
yenda pushed a commit that referenced this issue Mar 18, 2019
@goranjovic
refactor #7571 - decoupled request transaction from send transaction …
0a3a9d7 
…flow

Signed-off-by: Goran Jovic <goranjovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goranjovic goranjovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor #7571 - decoupled request transaction from send transaction … status-im/status-mobile
1 participant
@goranjovic