Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Back up seed phrase notification in wallet tappable and add display logic #8650

Closed
hesterbruikman opened this issue Jul 26, 2019 · 3 comments · Fixed by #9253
Closed

Comments

@hesterbruikman
Copy link
Contributor

hesterbruikman commented Jul 26, 2019

Type: Feature

Summary: The Wallet > Account explorer shows a notification [Back up your seed phrase]

  1. Notification needs to be tappable. When tapped it needs to open the back up seed phrase flow
  2. Notification needs to appear as soon as the user has assets in their wallet

Already implemented: Notification disappears once the user has completed the back up seed phrase flow.

  1. BONUS: the [!] icon need to be updated to tiny-warning icon @andmironov can you point to or provide the asset?
@rasom
Copy link
Contributor

rasom commented Oct 21, 2019

Notification needs to appear as soon as the user has assets in their wallet

just to double check, we don't want to show it unless user has some assets in their wallet, right?

@rasom rasom self-assigned this Oct 21, 2019
@hesterbruikman
Copy link
Contributor Author

just to double check, we don't want to show it unless user has some assets in their wallet, right?

Correct. Intention is to show the notification in:
Profile - at all times until backup process has been completed.
Wallet - only when the user has assets in any one of the accounts that is derived from the root key.

For example:

  1. I create a multiaccount (root key incl chat and wallet)
  2. I do not back up seed phrase > no notification in wallet
  3. I receive funds on initial account in wallet > notification in wallet
  4. I generate a new account derived from root key > notification in wallet
  5. I move all funds from the initial account to new account > notification in wallet

cc @andmironov @errorists

rasom added a commit that referenced this issue Oct 21, 2019
- notification is tappable
- appears only if user has nonzero balance and hasn't backed up seed yet
@rasom
Copy link
Contributor

rasom commented Oct 21, 2019

@hesterbruikman it should work as you described in #9253

rasom added a commit that referenced this issue Oct 21, 2019
- notification is tappable
- appears only if user has nonzero balance and hasn't backed up seed yet
rasom added a commit that referenced this issue Oct 21, 2019
- notification is tappable
- appears only if user has nonzero balance and hasn't backed up seed yet
rasom added a commit that referenced this issue Oct 22, 2019
- notification is tappable
- appears only if user has nonzero balance and hasn't backed up seed yet
- Fix e2e test for this change
AlphaSerpentis pushed a commit to AlphaSerpentis/status-react that referenced this issue Nov 4, 2019
- notification is tappable
- appears only if user has nonzero balance and hasn't backed up seed yet
- Fix e2e test for this change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants