Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use images the right way #9045

Closed
yenda opened this issue Sep 25, 2019 · 1 comment
Closed

Use images the right way #9045

yenda opened this issue Sep 25, 2019 · 1 comment

Comments

@yenda
Copy link
Contributor

yenda commented Sep 25, 2019

Problem

We have multiple way of using images

Implementation

https://facebook.github.io/react-native/docs/images

Remove

src/status_im/ethereum/macros.clj:26:(defmacro resolve-icons
src/status_im/ethereum/macros.clj:47:(defmacro resolve-native-currency-icons

Acceptance Criteria

No more images in android/ and ios/
@weekly-digest weekly-digest bot mentioned this issue Sep 29, 2019
Closed
@hesterbruikman
Copy link
Contributor

Superseded by images over Waku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yenda @hesterbruikman