We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Here's the Weekly Digest for status-im/status-react:
Last week 44 issues were created. Of these, 12 issues have been closed and 32 issues are still open.
💚 #9065 upgrade Go: 1.11 > 1.12, by jakubgs 💚 #9064 Pair code and PUK code in status should be hidden, by yenda 💚 #9063 Add currency conversions for signing sheet - Fixes #8027, by acolytec3 💚 #9062 Can recover account with seedphrase created with keycard, by Serhy 💚 #9061 Account balance is not fetched when multiaccount is created with keycard, by churik 💚 #9060 Update issue templates, by jakubgs 💚 #9059 Add warning message at the last PUK-code attempt, by churik 💚 #9058 Separate status-react issue templates into bug & feature, by rachelhamlin 💚 #9057 Nothing happens when holding keykard right back agains after error, by churik 💚 #9056 upgrade status-go with geth 1.9.5, by adambabik 💚 #9055 Can't restore keycard account or pair card ("Cannot retrieve a valid key for a given account" error), by churik 💚 #9054 Update Onboarding to include illustrations, by hesterbruikman 💚 #9053 keycard bugfixes, by dmitryn 💚 #9052 [#9025] fix keycard pairings persistence, by dmitryn 💚 #9051 [#9034] Turn off autosuggestion on seedphrase confirmation input, by flexsurfer 💚 #9050 Only allow BIP39 seedphrase, by yenda 💚 #9048 Remove UUID related code, by flexsurfer 💚 #9046 Can't type ENS name in "New chat" screen (when start typing "0X04" appears), by churik 💚 #9045 Use images the right way, by yenda 💚 #9044 Load big .js files in native part, by yenda 💚 #9043 Verify reagent/react-native rendering assumptions, by yenda 💚 #9039 Implement network fee slider & custom setting, by rachelhamlin 💚 #9038 build multiple APKs for different architectures, by jakubgs 💚 #9037 Error states for new Tx overview: contract & network fees, by rachelhamlin 💚 #9035 Platform check is being made at runtime instead of compile-time, by PombeirP 💚 #9034 Turn off autosuggestion on seedphrase confirmation input, by Serhy 💚 #9033 biometric, by flexsurfer 💚 #9028 Crash at attempt to use second multiaccount with keycard, by churik 💚 #9025 Can't proceed with creating account if cancel process on "Confirm seed phrase", by churik 💚 #9024 Obtain access to the contacts profile picture via the Status DApp API, by richard-ramos 💚 #9023 Redirect to blank Unlock screen if tap "Cancel" during onboarding flow, by churik 💚 #9022 wip images, by flexsurfer
❤️ #9049 Fixed multipleaccount test, by Serhy ❤️ #9047 Another fix for false failures, by churik ❤️ #9042 replace require-macro for defnstyle and defstyle, by yenda ❤️ #9041 Hide Account Export menu item in wallet for v1, by PombeirP ❤️ #9040 Hide 'export account' option for v1, by rachelhamlin ❤️ #9036 Small test for mobile sync popup, by churik ❤️ #9032 throw errors on dangerous behaviours, by yenda ❤️ #9031 hotfix styles.cljs, by yenda ❤️ #9030 Update logcat tests and disable upgrade-app test, by Serhy ❤️ #9029 remove wrap-first-time, by yenda ❤️ #9027 [Snyk] Fix for 2 vulnerabilities, by snyk-bot ❤️ #9026 [#8516] Cannot delete dapp from "Recent", by flexsurfer
👍 #9050 Only allow BIP39 seedphrase, by yenda It received 👍 x2, 😄 x0, 🎉 x0 and ❤️ x1.
🔈 #9033 biometric, by flexsurfer It received 41 comments.
Last week, 34 pull requests were created, updated or merged.
Last week, 14 pull requests were updated. 💛 #9065 upgrade Go: 1.11 > 1.12, by jakubgs 💛 #9060 Update issue templates, by jakubgs 💛 #9056 upgrade status-go with geth 1.9.5, by adambabik 💛 #9053 keycard bugfixes, by dmitryn 💛 #9052 [#9025] fix keycard pairings persistence, by dmitryn 💛 #9051 [#9034] Turn off autosuggestion on seedphrase confirmation input, by flexsurfer 💛 #9038 build multiple APKs for different architectures, by jakubgs 💛 #9033 biometric, by flexsurfer 💛 #9022 wip images, by flexsurfer 💛 #9009 Network fee error changed from tooltip to red text, by igormuba 💛 #8985 Fix sticker pack installation buttons, by igetgames 💛 #8959 Fix small UI problems with the compose reply screen, by alexjg 💛 #8903 Onboarding ui touchups, by siphiuel 💛 #8630 [WIP] Desktop two-pane UI with react-navigation v3, by vkjr
Last week, 20 pull requests were merged. 💜 #9049 Fixed multipleaccount test, by Serhy 💜 #9047 Another fix for false failures, by churik 💜 #9042 replace require-macro for defnstyle and defstyle, by yenda 💜 #9041 Hide Account Export menu item in wallet for v1, by PombeirP 💜 #9036 Small test for mobile sync popup, by churik 💜 #9032 throw errors on dangerous behaviours, by yenda 💜 #9031 hotfix styles.cljs, by yenda 💜 #9030 Update logcat tests and disable upgrade-app test, by Serhy 💜 #9029 remove wrap-first-time, by yenda 💜 #9026 [#8516] Cannot delete dapp from "Recent", by flexsurfer 💜 #9021 Use modern build system for iOS, by PombeirP 💜 #9020 Fix app version and deeplink tests, by Serhy 💜 #9016 typos in REVIEW.md, by yenda 💜 #9014 fix #8992 update account timestamp when login with keycard, by yenda 💜 #9013 Add changes to PR checklist discussed in Istanbul, by PombeirP 💜 #9012 Bump @react-native-community/netinfo from 4.2.1 to 4.2.2 in /mobile/js_files, by dependabot-preview[bot] 💜 #9011 Bump qrcode from 1.4.1 to 1.4.2 in /mobile/js_files, by dependabot-preview[bot] 💜 #9010 Bump qrcode from 1.4.1 to 1.4.2 in /desktop/js_files, by dependabot-preview[bot] 💜 #9006 Use identicon / gfycat from status-go, by cammellos 💜 #9005 [#8968] custom seed phrase popover, by dmitryn
Last week there were 22 commits. 🛠️ Hide Account Export menu item in wallet for v1. Closes #9040 Signed-off-by: yenda eric@status.im by PombeirP 🛠️ Add gfycat/identicon from status-go Signed-off-by: yenda eric@status.im by cammellos 🛠️ Fix multipleaccount test Signed-off-by: Serhy sergii@status.im by Serhy 🛠️ throw errors on dangerous behaviours - if multiaccount settings are saved on top of an empty map or nil, this means something went wrong, the state of the app is unstable, and actually saving will result in loss of data. It should never happen, but if it does, throw and error and abort. - sometimes two fxs are merged when they shouldn't, this is caused by bugs and should never happen, but if it does, throw an error with arguments for both effects to help localize the error Signed-off-by: yenda eric@status.im by yenda 🛠️ replace require-macro for defnstyle and defstyle - renamed the macros def and defn so that they are now used with aliased namespace styles/def and styles/defn to force user to use aliased require instead of require-macro and refer - this makes sure the cljs file is required which includes the require for platform ns needed after macroexpension Signed-off-by: yenda eric@status.im by yenda 🛠️ Another fix for false failures Signed-off-by: Churikova Tetiana churikova.tm@gmail.com by churik 🛠️ Mobile popup Signed-off-by: Churikova Tetiana churikova.tm@gmail.com by churik 🛠️ Update logcat tests Signed-off-by: Serhy sergii@status.im by Serhy 🛠️ [#8968] custom seed phrase popover Signed-off-by: yenda eric@status.im by dmitryn 🛠️ hotfix styles.cljs Signed-off-by: yenda eric@status.im by yenda 🛠️ remove wrap-first-time Signed-off-by: yenda eric@status.im by yenda 🛠️ Modified e2e for deleting-clear all dapps Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by churik 🛠️ [#8516] Cannot delete dapp from "Recent" by flexsurfer 🛠️ fix #8992 update account timestamp when login with keycard Logout from keycard account was redirecting to login screen for another user because b.multiaccountsDB.UpdateAccountTimestamp was not called in startNodeWithKey as it was done in startNodeWithAccount in status-go The fix is therefore in status-go and this PR updates status-go version to fix that Signed-off-by: yenda eric@status.im by yenda 🛠️ Bump qrcode from 1.4.1 to 1.4.2 in /mobile/js_files Bumps qrcode from 1.4.1 to 1.4.2. - Release notes - Changelog - Commits Signed-off-by: dependabot-preview[bot] support@dependabot.com by dependabot-preview[bot] 🛠️ Bump qrcode from 1.4.1 to 1.4.2 in /desktop/js_files Bumps qrcode from 1.4.1 to 1.4.2. - Release notes - Changelog - Commits Signed-off-by: dependabot-preview[bot] support@dependabot.com by dependabot-preview[bot] 🛠️ Bump @react-native-community/netinfo in /mobile/js_filesBumps @react-native-community/netinfo from 4.2.1 to 4.2.2.- Release notes- Changelog- CommitsSigned-off-by: dependabot-preview[bot] support@dependabot.com by dependabot-preview[bot] 🛠️ Fix app version and deeplink tests Signed-off-by: Serhy sergii@status.im by Serhy 🛠️ Add changes to PR checklist discussed in Istanbul Signed-off-by: Pedro Pombeiro pombeirp@users.noreply.github.com by PombeirP 🛠️ typos in REVIEW.md Signed-off-by: yenda eric@status.im by yenda 🛠️ nix: Update fastlane Gemset Signed-off-by: yenda eric@status.im by PombeirP 🛠️ Use modern build system for iOS by PombeirP
styles/def
styles/defn
b.multiaccountsDB.UpdateAccountTimestamp
startNodeWithKey
startNodeWithAccount
Last week there were 8 contributors. 👤 PombeirP 👤 cammellos 👤 Serhy 👤 yenda 👤 churik 👤 dmitryn 👤 flexsurfer 👤 dependabot-preview[bot]
Last week there were 3 stagazers. ⭐ Victorcccc ⭐ pushpendrapratap ⭐ crodas You all are the stars! 🌟
Last week there were no releases.
That's all for last week, please 👀 Watch and ⭐ Star the repository status-im/status-react to receive next weekly updates. 😃
You can also view all Weekly Digests by clicking here.
Your Weekly Digest bot. 📆
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Here's the Weekly Digest for status-im/status-react:
ISSUES
Last week 44 issues were created.
Of these, 12 issues have been closed and 32 issues are still open.
OPEN ISSUES
💚 #9065 upgrade Go: 1.11 > 1.12, by jakubgs
💚 #9064 Pair code and PUK code in status should be hidden, by yenda
💚 #9063 Add currency conversions for signing sheet - Fixes #8027, by acolytec3
💚 #9062 Can recover account with seedphrase created with keycard, by Serhy
💚 #9061 Account balance is not fetched when multiaccount is created with keycard, by churik
💚 #9060 Update issue templates, by jakubgs
💚 #9059 Add warning message at the last PUK-code attempt, by churik
💚 #9058 Separate status-react issue templates into bug & feature, by rachelhamlin
💚 #9057 Nothing happens when holding keykard right back agains after error, by churik
💚 #9056 upgrade status-go with geth 1.9.5, by adambabik
💚 #9055 Can't restore keycard account or pair card ("Cannot retrieve a valid key for a given account" error), by churik
💚 #9054 Update Onboarding to include illustrations, by hesterbruikman
💚 #9053 keycard bugfixes, by dmitryn
💚 #9052 [#9025] fix keycard pairings persistence, by dmitryn
💚 #9051 [#9034] Turn off autosuggestion on seedphrase confirmation input, by flexsurfer
💚 #9050 Only allow BIP39 seedphrase, by yenda
💚 #9048 Remove UUID related code, by flexsurfer
💚 #9046 Can't type ENS name in "New chat" screen (when start typing "0X04" appears), by churik
💚 #9045 Use images the right way, by yenda
💚 #9044 Load big .js files in native part, by yenda
💚 #9043 Verify reagent/react-native rendering assumptions, by yenda
💚 #9039 Implement network fee slider & custom setting, by rachelhamlin
💚 #9038 build multiple APKs for different architectures, by jakubgs
💚 #9037 Error states for new Tx overview: contract & network fees, by rachelhamlin
💚 #9035 Platform check is being made at runtime instead of compile-time, by PombeirP
💚 #9034 Turn off autosuggestion on seedphrase confirmation input, by Serhy
💚 #9033 biometric, by flexsurfer
💚 #9028 Crash at attempt to use second multiaccount with keycard, by churik
💚 #9025 Can't proceed with creating account if cancel process on "Confirm seed phrase", by churik
💚 #9024 Obtain access to the contacts profile picture via the Status DApp API, by richard-ramos
💚 #9023 Redirect to blank Unlock screen if tap "Cancel" during onboarding flow, by churik
💚 #9022 wip images, by flexsurfer
CLOSED ISSUES
❤️ #9049 Fixed multipleaccount test, by Serhy
❤️ #9047 Another fix for false failures, by churik
❤️ #9042 replace require-macro for defnstyle and defstyle, by yenda
❤️ #9041 Hide Account Export menu item in wallet for v1, by PombeirP
❤️ #9040 Hide 'export account' option for v1, by rachelhamlin
❤️ #9036 Small test for mobile sync popup, by churik
❤️ #9032 throw errors on dangerous behaviours, by yenda
❤️ #9031 hotfix styles.cljs, by yenda
❤️ #9030 Update logcat tests and disable upgrade-app test, by Serhy
❤️ #9029 remove wrap-first-time, by yenda
❤️ #9027 [Snyk] Fix for 2 vulnerabilities, by snyk-bot
❤️ #9026 [#8516] Cannot delete dapp from "Recent", by flexsurfer
LIKED ISSUE
👍 #9050 Only allow BIP39 seedphrase, by yenda
It received 👍 x2, 😄 x0, 🎉 x0 and ❤️ x1.
NOISY ISSUE
🔈 #9033 biometric, by flexsurfer
It received 41 comments.
PULL REQUESTS
Last week, 34 pull requests were created, updated or merged.
UPDATED PULL REQUEST
Last week, 14 pull requests were updated.
💛 #9065 upgrade Go: 1.11 > 1.12, by jakubgs
💛 #9060 Update issue templates, by jakubgs
💛 #9056 upgrade status-go with geth 1.9.5, by adambabik
💛 #9053 keycard bugfixes, by dmitryn
💛 #9052 [#9025] fix keycard pairings persistence, by dmitryn
💛 #9051 [#9034] Turn off autosuggestion on seedphrase confirmation input, by flexsurfer
💛 #9038 build multiple APKs for different architectures, by jakubgs
💛 #9033 biometric, by flexsurfer
💛 #9022 wip images, by flexsurfer
💛 #9009 Network fee error changed from tooltip to red text, by igormuba
💛 #8985 Fix sticker pack installation buttons, by igetgames
💛 #8959 Fix small UI problems with the compose reply screen, by alexjg
💛 #8903 Onboarding ui touchups, by siphiuel
💛 #8630 [WIP] Desktop two-pane UI with react-navigation v3, by vkjr
MERGED PULL REQUEST
Last week, 20 pull requests were merged.
💜 #9049 Fixed multipleaccount test, by Serhy
💜 #9047 Another fix for false failures, by churik
💜 #9042 replace require-macro for defnstyle and defstyle, by yenda
💜 #9041 Hide Account Export menu item in wallet for v1, by PombeirP
💜 #9036 Small test for mobile sync popup, by churik
💜 #9032 throw errors on dangerous behaviours, by yenda
💜 #9031 hotfix styles.cljs, by yenda
💜 #9030 Update logcat tests and disable upgrade-app test, by Serhy
💜 #9029 remove wrap-first-time, by yenda
💜 #9026 [#8516] Cannot delete dapp from "Recent", by flexsurfer
💜 #9021 Use modern build system for iOS, by PombeirP
💜 #9020 Fix app version and deeplink tests, by Serhy
💜 #9016 typos in REVIEW.md, by yenda
💜 #9014 fix #8992 update account timestamp when login with keycard, by yenda
💜 #9013 Add changes to PR checklist discussed in Istanbul, by PombeirP
💜 #9012 Bump @react-native-community/netinfo from 4.2.1 to 4.2.2 in /mobile/js_files, by dependabot-preview[bot]
💜 #9011 Bump qrcode from 1.4.1 to 1.4.2 in /mobile/js_files, by dependabot-preview[bot]
💜 #9010 Bump qrcode from 1.4.1 to 1.4.2 in /desktop/js_files, by dependabot-preview[bot]
💜 #9006 Use identicon / gfycat from status-go, by cammellos
💜 #9005 [#8968] custom seed phrase popover, by dmitryn
COMMITS
Last week there were 22 commits.
🛠️ Hide Account Export menu item in wallet for v1. Closes #9040 Signed-off-by: yenda eric@status.im by PombeirP
🛠️ Add gfycat/identicon from status-go Signed-off-by: yenda eric@status.im by cammellos
🛠️ Fix multipleaccount test Signed-off-by: Serhy sergii@status.im by Serhy
🛠️ throw errors on dangerous behaviours - if multiaccount settings are saved on top of an empty map or nil, this means something went wrong, the state of the app is unstable, and actually saving will result in loss of data. It should never happen, but if it does, throw and error and abort. - sometimes two fxs are merged when they shouldn't, this is caused by bugs and should never happen, but if it does, throw an error with arguments for both effects to help localize the error Signed-off-by: yenda eric@status.im by yenda
🛠️ replace require-macro for defnstyle and defstyle - renamed the macros def and defn so that they are now used with aliased namespace
styles/defandstyles/defnto force user to use aliased require instead of require-macro and refer - this makes sure the cljs file is required which includes the require for platform ns needed after macroexpension Signed-off-by: yenda eric@status.im by yenda🛠️ Another fix for false failures Signed-off-by: Churikova Tetiana churikova.tm@gmail.com by churik
🛠️ Mobile popup Signed-off-by: Churikova Tetiana churikova.tm@gmail.com by churik
🛠️ Update logcat tests Signed-off-by: Serhy sergii@status.im by Serhy
🛠️ [#8968] custom seed phrase popover Signed-off-by: yenda eric@status.im by dmitryn
🛠️ hotfix styles.cljs Signed-off-by: yenda eric@status.im by yenda
🛠️ remove wrap-first-time Signed-off-by: yenda eric@status.im by yenda
🛠️ Modified e2e for deleting-clear all dapps Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by churik
🛠️ [#8516] Cannot delete dapp from "Recent" by flexsurfer
🛠️ fix #8992 update account timestamp when login with keycard Logout from keycard account was redirecting to login screen for another user because
b.multiaccountsDB.UpdateAccountTimestampwas not called instartNodeWithKeyas it was done instartNodeWithAccountin status-go The fix is therefore in status-go and this PR updates status-go version to fix that Signed-off-by: yenda eric@status.im by yenda🛠️ Bump qrcode from 1.4.1 to 1.4.2 in /mobile/js_files Bumps qrcode from 1.4.1 to 1.4.2. - Release notes - Changelog - Commits Signed-off-by: dependabot-preview[bot] support@dependabot.com by dependabot-preview[bot]
🛠️ Bump qrcode from 1.4.1 to 1.4.2 in /desktop/js_files Bumps qrcode from 1.4.1 to 1.4.2. - Release notes - Changelog - Commits Signed-off-by: dependabot-preview[bot] support@dependabot.com by dependabot-preview[bot]
🛠️ Bump @react-native-community/netinfo in /mobile/js_filesBumps @react-native-community/netinfo from 4.2.1 to 4.2.2.- Release notes- Changelog- CommitsSigned-off-by: dependabot-preview[bot] support@dependabot.com by dependabot-preview[bot]
🛠️ Fix app version and deeplink tests Signed-off-by: Serhy sergii@status.im by Serhy
🛠️ Add changes to PR checklist discussed in Istanbul Signed-off-by: Pedro Pombeiro pombeirp@users.noreply.github.com by PombeirP
🛠️ typos in REVIEW.md Signed-off-by: yenda eric@status.im by yenda
🛠️ nix: Update fastlane Gemset Signed-off-by: yenda eric@status.im by PombeirP
🛠️ Use modern build system for iOS by PombeirP
CONTRIBUTORS
Last week there were 8 contributors.
👤 PombeirP
👤 cammellos
👤 Serhy
👤 yenda
👤 churik
👤 dmitryn
👤 flexsurfer
👤 dependabot-preview[bot]
STARGAZERS
Last week there were 3 stagazers.
⭐ Victorcccc
⭐ pushpendrapratap
⭐ crodas
You all are the stars! 🌟
RELEASES
Last week there were no releases.
That's all for last week, please 👀 Watch and ⭐ Star the repository status-im/status-react to receive next weekly updates. 😃
You can also view all Weekly Digests by clicking here.
The text was updated successfully, but these errors were encountered: