-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace require-macro for defnstyle and defstyle #9042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins Builds
|
vkjr
approved these changes
Sep 25, 2019
98% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (45)Click to expand |
@churik is it a known e2e fail? |
Tested on One Plus 7 Pro creating account and trying out different screens, + fixes compilation and runtime error on desktop |
It is not related to your PR for sure. |
yenda
force-pushed
the
fix/defnstyle-macro
branch
from
September 25, 2019 15:17
67fe6ec
to
3ab49e2
Compare
- renamed the macros def and defn so that they are now used with aliased namespace `styles/def` and `styles/defn` to force user to use aliased require instead of require-macro and refer - this makes sure the cljs file is required which includes the require for platform ns needed after macroexpension Signed-off-by: yenda <eric@status.im>
yenda
force-pushed
the
fix/defnstyle-macro
branch
from
September 25, 2019 15:18
3ab49e2
to
bf6b328
Compare
96% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (45)Click to expand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namespace
styles/def
andstyles/defn
to force user to use aliased requireinstead of require-macro and refer
platform ns needed after macroexpension
status: ready