Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network fee error changed from tooltip to red text #9009

Closed
wants to merge 1 commit into from

Conversation

igormuba
Copy link

If you submit PR for issue with bounty then write here Fixes #NN where NN is issue number
#8485

Functional
  • 1-1 chats
  • public chats
  • group chats
  • wallet / transactions
  • dapps / app browsing
  • account recovery
  • new account
  • user profile updates
  • networks
  • mailservers
  • fleet
  • bootnodes
Non-functional
  • battery performance
  • CPU performance / speed of the app
  • network consumption

Steps to test

  • Open Status
  • Click on your wallet
  • Choose "send"
  • Fill the wallet field
  • On the amount field input the maximum amount you have on your wallet, so that you see the error
  • Proceed to sign
  • You will see the red message saying that, because you are transfering all you have, you don't have anything left for fees

status: ready

@igormuba igormuba requested a review from a team as a code owner September 20, 2019 03:37
@status-github-bot
Copy link

Hey @igormuba, and thank you so much for making your first pull request in status-react! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented Sep 20, 2019

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
d2a8a23 #1 2019-09-20 03:48:33 ~10 min ios 📄 log
d2a8a23 #1 2019-09-20 03:50:21 ~12 min android-e2e 📄 log
d2a8a23 #1 2019-09-20 03:50:27 ~12 min macos 📄 log
d2a8a23 #1 2019-09-20 03:50:28 ~12 min android 📄 log
d2a8a23 #1 2019-09-20 03:51:37 ~13 min linux 📄 log
d2a8a23 #1 2019-09-20 03:52:48 ~14 min windows 📄 log

@yenda
Copy link
Contributor

yenda commented Sep 24, 2019

@flexsurfer shouldn't it be an option rather than a different element?

@flexsurfer
Copy link
Member

thanks, @igormuba , but the purpose of list-item is to have one component with options, could you please add an option to 'list-item instead duplication of component, thanks

@rachelhamlin
Copy link
Contributor

Let's actually pause work on this PR @igormuba before you make any changes to the list-item. I want to ensure we're meeting the spec, and it looks like we've got some confusion. I'm going to merge #8485 and #8691 into one, I think, and then we can recommission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants