Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Account Export menu item in wallet for v1 #9041

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Hide Account Export menu item in wallet for v1 #9041

merged 1 commit into from
Sep 28, 2019

Conversation

pedropombeiro
Copy link
Contributor

@pedropombeiro pedropombeiro commented Sep 25, 2019 •
edited by StatusWrike
Loading

Closes #9040

Summary

This PR hides the Export Account menu item in the wallet.

Testing notes

Tested on Android device.

image

Platforms

  • iOS

status: ready

@pedropombeiro pedropombeiro requested a review from a team as a code owner September 25, 2019 13:03
@pedropombeiro pedropombeiro self-assigned this Sep 25, 2019
@auto-assign auto-assign bot removed the request for review from a team September 25, 2019 13:03
@status-github-bot
Copy link

status-github-bot bot commented Sep 25, 2019 •
edited by pedropombeiro
Loading

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Sep 25, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a777279 #1 2019-09-25 13:12:14 ~8 min ios 📦 ipa
✔️ a777279 #1 2019-09-25 13:15:57 ~12 min macos 📦 dmg
✔️ a777279 #1 2019-09-25 13:17:47 ~14 min linux 📦 App
✔️ a777279 #1 2019-09-25 13:18:33 ~15 min windows 📦 exe
✔️ a777279 #1 2019-09-25 13:20:35 ~17 min android 📦 apk
✔️ a777279 #1 2019-09-25 13:21:35 ~18 min android-e2e 📦 apk
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6d6d4be #2 2019-09-25 13:40:45 ~11 min ios 📦 ipa
✔️ 6d6d4be #2 2019-09-25 13:42:40 ~13 min macos 📦 dmg
✔️ 6d6d4be #2 2019-09-25 13:46:14 ~16 min android-e2e 📦 apk
✔️ 6d6d4be #2 2019-09-25 13:46:16 ~16 min android 📦 apk
✔️ 6d6d4be #2 2019-09-25 13:49:31 ~20 min linux 📦 App
✔️ 6d6d4be #2 2019-09-25 13:57:29 ~28 min windows 📦 exe
✔️ b3bdfa1 #3 2019-09-27 13:21:36 ~9 min ios 📦 ipa
✔️ b3bdfa1 #3 2019-09-27 13:24:47 ~12 min linux 📦 App
✔️ b3bdfa1 #3 2019-09-27 13:25:14 ~13 min macos 📦 dmg
✔️ b3bdfa1 #3 2019-09-27 13:27:36 ~15 min windows 📦 exe
✔️ b3bdfa1 #3 2019-09-27 13:29:06 ~17 min android-e2e 📦 apk
✔️ b3bdfa1 #3 2019-09-27 13:29:06 ~17 min android 📦 apk

@pedropombeiro
Copy link
Contributor Author

cc @errorists regarding changed UI

@errorists
Copy link
Contributor

Looks good Pedro!

@yenda
Copy link
Contributor

yenda commented Sep 28, 2019

Tested on iOS though that wasn't really necessary considering the changes
Image-1 (1)

Hide Account Export menu item in wallet for v1. Closes #9040
f8d447f 
Signed-off-by: yenda <eric@status.im>
@yenda yenda merged commit f8d447f into develop Sep 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/remove-account-export branch September 28, 2019 12:00
@weekly-digest weekly-digest bot mentioned this pull request Sep 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@yenda yenda Awaiting requested review from yenda

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide 'export account' option for v1
5 participants
@pedropombeiro @status-im-auto @errorists @yenda @flexsurfer