-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use modern build system for iOS #9021
Conversation
Pull Request Checklist
|
b598c1f
to
ff6d10a
Compare
Jenkins BuildsClick to see older builds (10)
|
9b2b824
to
d4bc7c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, the main change is dropping UseModernBuildSystem=N
, but I approve of the formatting fixes and Fastlane upgrade too. Nice.
Uh oh, but are we sure we want to skip manual QA? This is a big change in build system. |
98% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (45)Click to expand |
d4bc7c7
to
62ea67d
Compare
True, especially since I don't have an iOS device to test on. Dropping the label. @churik do you have an iOS device you could test this with? It should be enough to just open the app and create an account. |
62ea67d
to
9b1dafa
Compare
On iOS 12.4.1 (iPhoneX) can install Status, can create new and can recover successfully accounts. |
Signed-off-by: yenda <eric@status.im>
9b1dafa
to
97e9f0d
Compare
Summary
This PR gets rid of the code to use the legacy build system for iOS to work around an issue with Xcode 10.1 (we now require 10.2.1). It also does a bit of reformatting (using Rubocop) and simplification of the Ruby code.
status: ready