Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern build system for iOS #9021

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Use modern build system for iOS #9021

merged 2 commits into from
Sep 23, 2019

Conversation

pedropombeiro
Copy link
Contributor

@pedropombeiro pedropombeiro commented Sep 21, 2019 •
edited by StatusWrike
Loading

Summary

This PR gets rid of the code to use the legacy build system for iOS to work around an issue with Xcode 10.1 (we now require 10.2.1). It also does a bit of reformatting (using Rubocop) and simplification of the Ruby code.

status: ready

@pedropombeiro pedropombeiro self-assigned this Sep 21, 2019
@status-github-bot
Copy link

status-github-bot bot commented Sep 21, 2019 •
edited by pedropombeiro
Loading

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@pedropombeiro pedropombeiro force-pushed the fix/use-modern-build-system branch 3 times, most recently from b598c1f to ff6d10a Compare September 21, 2019 10:00
@status-im-auto
Copy link
Member

status-im-auto commented Sep 21, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (10)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ff6d10a #4 2019-09-21 10:09:23 ~8 min ios 📦 ipa
✔️ ff6d10a #4 2019-09-21 10:12:56 ~12 min android 📦 apk
✔️ ff6d10a #4 2019-09-21 10:12:56 ~12 min macos 📦 dmg
✔️ ff6d10a #4 2019-09-21 10:13:23 ~12 min android-e2e 📦 apk
✔️ 9b2b824 #5 2019-09-21 10:23:03 ~9 min ios 📦 ipa
✔️ 9b2b824 #5 2019-09-21 10:24:37 ~11 min android 📦 apk
✔️ 9b2b824 #5 2019-09-21 10:25:10 ~11 min macos 📦 dmg
✔️ 9b2b824 #5 2019-09-21 10:26:08 ~12 min linux 📦 App
✔️ 9b2b824 #5 2019-09-21 10:27:01 ~13 min android-e2e 📦 apk
✔️ 9b2b824 #5 2019-09-21 10:28:12 ~15 min windows 📦 exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d4bc7c7 #6 2019-09-21 13:25:33 ~10 min ios 📦 ipa
✔️ d4bc7c7 #6 2019-09-21 13:27:27 ~11 min macos 📦 dmg
✔️ d4bc7c7 #6 2019-09-21 13:29:38 ~14 min linux 📦 App
✔️ d4bc7c7 #6 2019-09-21 13:30:26 ~14 min android-e2e 📦 apk
✔️ d4bc7c7 #6 2019-09-21 13:30:31 ~15 min android 📦 apk
✔️ d4bc7c7 #6 2019-09-21 13:30:59 ~15 min windows 📦 exe
✔️ 9b1dafa #8 2019-09-23 07:21:23 ~8 min ios 📦 ipa
✔️ 9b1dafa #8 2019-09-23 07:24:06 ~11 min macos 📦 dmg
✔️ 9b1dafa #8 2019-09-23 07:24:24 ~11 min android-e2e 📦 apk
✔️ 9b1dafa #8 2019-09-23 07:24:39 ~12 min android 📦 apk
✔️ 9b1dafa #8 2019-09-23 07:26:53 ~14 min linux 📦 App
✔️ 9b1dafa #8 2019-09-23 07:28:14 ~15 min windows 📦 exe

jakubgs
jakubgs approved these changes Sep 22, 2019
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, the main change is dropping UseModernBuildSystem=N, but I approve of the formatting fixes and Fastlane upgrade too. Nice.

@jakubgs
Copy link
Member

jakubgs commented Sep 22, 2019

Uh oh, but are we sure we want to skip manual QA? This is a big change in build system.

@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 46
Failed tests: 1
Passed tests: 45

Failed tests (1)

Click to expand
1. test_send_two_transactions_one_after_another_in_dapp

Device 1: Wait for EnterPasswordInput
Device 1: Wait for EnterPasswordInput

Device 1: 'EnterPasswordInput' is not found on the screen

Device sessions

Passed tests (45)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_ens_in_public_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_send_message_in_group_chat
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_send_token_with_7_decimals
Device sessions

19. test_offline_messaging_1_1_chat
Device sessions

20. test_modify_transaction_fee_values
Device sessions

21. test_send_eth_from_wallet_to_address
Device sessions

22. test_add_account_to_multiaccount_instance
Device sessions

23. test_manage_assets
Device sessions

24. test_long_press_to_delete_public_chat
Device sessions

25. test_send_emoji
Device sessions

26. test_search_chat_on_home
Device sessions

27. test_logcat_recovering_account
Device sessions

28. test_can_add_existing_ens
Device sessions

29. test_messaging_in_different_networks
Device sessions

30. test_logcat_sign_message_from_daap
Device sessions

31. test_switch_users_and_add_new_account
Device sessions

32. test_send_stt_from_wallet
Device sessions

33. test_login_with_new_account
Device sessions

34. test_start_chat_with_ens
Device sessions

35. test_add_contact_from_public_chat
Device sessions

36. test_password_in_logcat_creating_account
Device sessions

37. test_backup_recovery_phrase
Device sessions

38. test_offline_status
Device sessions

39. test_open_google_com_via_open_dapp
Device sessions

40. test_unread_messages_counter_public_chat
Device sessions

41. test_sign_message_from_daap
Device sessions

42. test_user_can_remove_profile_picture
Device sessions

43. test_share_contact_code_and_wallet_address
Device sessions

44. test_refresh_button_browsing_app_webview
Device sessions

45. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@pedropombeiro
Copy link
Contributor Author

Uh oh, but are we sure we want to skip manual QA? This is a big change in build system.

True, especially since I don't have an iOS device to test on. Dropping the label. @churik do you have an iOS device you could test this with? It should be enough to just open the app and create an account.

@Serhy
Copy link
Contributor

Serhy commented Sep 23, 2019

On iOS 12.4.1 (iPhoneX) can install Status, can create new and can recover successfully accounts.
Message history is loaded, messages exchanged between two contacts in 1-1 chat fine

@Serhy Serhy self-assigned this Sep 23, 2019
nix: Update fastlane Gemset
97e9f0d 
Signed-off-by: yenda <eric@status.im>
@yenda yenda merged commit 97e9f0d into develop Sep 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/use-modern-build-system branch September 23, 2019 12:06
@weekly-digest weekly-digest bot mentioned this pull request Sep 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

Assignees
No one assigned
Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pedropombeiro @status-im-auto @jakubgs @statustestbot @Serhy @yenda