Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9034] Turn off autosuggestion on seedphrase confirmation input #9051

Merged
merged 1 commit into from
Sep 30, 2019
Merged

[#9034] Turn off autosuggestion on seedphrase confirmation input #9051

merged 1 commit into from
Sep 30, 2019

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Sep 26, 2019 •
edited by StatusWrike
Loading

fixes #9034

@flexsurfer flexsurfer requested a review from a team as a code owner September 26, 2019 12:40
@flexsurfer flexsurfer self-assigned this Sep 26, 2019
@auto-assign auto-assign bot removed the request for review from a team September 26, 2019 12:40
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

yenda
yenda reviewed Sep 26, 2019
View reviewed changes
src/status_im/ui/components/text_input/view.cljs Outdated
@@ -14,7 +14,7 @@
(dissoc merged-styles :background-color)
merged-styles)))

(defn text-input-with-label [{:keys [label content error style height container text editable] :as props :or {editable true}}]
(defn text-input-with-label [{:keys [label content error style height container text editable keyboard-type] :as props :or {editable true}}]
Copy link
Contributor

@yenda yenda Sep 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(defn text-input-with-label [{:keys [label content error style height container text editable keyboard-type] :as props :or {editable true}}]
(defn text-input-with-label
[{:keys [label content error style height container text editable keyboard-type]
:as props
:or {editable true}}]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please break the line it is too long

@status-im-auto
Copy link
Member

status-im-auto commented Sep 26, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e516544 #1 2019-09-26 12:54:21 ~13 min android-e2e 📦 apk
✔️ e516544 #1 2019-09-26 12:54:21 ~13 min ios 📦 ipa
✔️ e516544 #1 2019-09-26 12:54:33 ~13 min android 📦 apk
✔️ e516544 #1 2019-09-26 12:54:39 ~13 min linux 📦 App
✔️ e516544 #1 2019-09-26 12:56:33 ~15 min macos 📦 dmg
✔️ e516544 #1 2019-09-26 13:01:47 ~21 min windows 📦 exe
✔️ 2ac0ca0 #2 2019-09-30 08:48:26 ~10 min ios 📦 ipa
✔️ 2ac0ca0 #2 2019-09-30 08:52:16 ~13 min macos 📦 dmg
✔️ 2ac0ca0 #2 2019-09-30 08:53:06 ~14 min android 📦 apk
✔️ 2ac0ca0 #2 2019-09-30 08:54:34 ~16 min linux 📦 App
✔️ 2ac0ca0 #2 2019-09-30 08:56:09 ~17 min android-e2e 📦 apk
✔️ 2ac0ca0 #2 2019-09-30 08:57:16 ~18 min windows 📦 exe

@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 47
Failed tests: 1
Passed tests: 46

Failed tests (1)

Click to expand
1. test_messaging_in_different_networks

Device 2: Wait for OkButton
Device 2: Wait for ContinueButton

Device 1: 'GetStartedButton' is not found on the screen

Device sessions

Passed tests (46)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_ens_in_public_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_send_message_in_group_chat
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_send_token_with_7_decimals
Device sessions

19. test_offline_messaging_1_1_chat
Device sessions

20. test_modify_transaction_fee_values
Device sessions

21. test_send_eth_from_wallet_to_address
Device sessions

22. test_add_account_to_multiaccount_instance
Device sessions

23. test_manage_assets
Device sessions

24. test_long_press_to_delete_public_chat
Device sessions

25. test_send_emoji
Device sessions

26. test_search_chat_on_home
Device sessions

27. test_logcat_recovering_account
Device sessions

28. test_can_add_existing_ens
Device sessions

29. test_logcat_backup_recovery_phrase
Device sessions

30. test_logcat_sign_message_from_daap
Device sessions

31. test_switch_users_and_add_new_account
Device sessions

32. test_send_stt_from_wallet
Device sessions

33. test_login_with_new_account
Device sessions

34. test_start_chat_with_ens
Device sessions

35. test_add_contact_from_public_chat
Device sessions

36. test_send_two_transactions_one_after_another_in_dapp
Device sessions

37. test_password_in_logcat_creating_account
Device sessions

38. test_backup_recovery_phrase
Device sessions

39. test_offline_status
Device sessions

40. test_open_google_com_via_open_dapp
Device sessions

41. test_unread_messages_counter_public_chat
Device sessions

42. test_sign_message_from_daap
Device sessions

43. test_user_can_remove_profile_picture
Device sessions

44. test_share_contact_code_and_wallet_address
Device sessions

45. test_refresh_button_browsing_app_webview
Device sessions

46. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@yenda
Copy link
Contributor

yenda commented Sep 28, 2019

@flexsurfer please include my suggestion in the commit.

Also I tested and the suggestion is gone in the profile but they are still there when you are creating an account with keycard and you are asked to confirm seed phrase

@weekly-digest weekly-digest bot mentioned this pull request Sep 29, 2019
Closed
@flexsurfer
[#9034] Turn off autosuggestion on seedphrase confirmation input
6a73257 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit 6a73257 into develop Sep 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the bug/seed-suggestions branch September 30, 2019 08:39
@yenda
Copy link
Contributor

yenda commented Sep 30, 2019

why you merged the suggestion are still there in onboarding :(

@flexsurfer
Copy link
Member Author

@yenda my bad, hadn't seen your comment :(

@flexsurfer
Copy link
Member Author

#9069

@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenda yenda yenda left review comments

@dmitryn dmitryn dmitryn approved these changes

@vitvly vitvly vitvly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn off autosuggestion on seedphrase confirmation input
6 participants
@flexsurfer @status-im-auto @statustestbot @yenda @dmitryn @vitvly