Fix small UI problems with the compose reply screen #8959

alexjg · 2019-09-09T23:31:50Z

Summary

Implements the small design tweaks in the linked issue

status: ready

I've attached a screenshot of this running on a Pixel 2. I haven't tested on an iDevice.

status-github-bot · 2019-09-09T23:31:55Z

Hey @alexjg, and thank you so much for making your first pull request in status-react! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

status-github-bot · 2019-09-09T23:31:56Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?

status-im-auto · 2019-09-09T23:41:01Z

Jenkins Builds

Click to see older builds (49)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`2746b0d`	#1	2019-09-09 23:41:01	~8 min	`ios`	📄`log`
❌	`2746b0d`	#1	2019-09-09 23:45:39	~13 min	`android-e2e`	📄`log`
❌	`2746b0d`	#1	2019-09-09 23:48:41	~16 min	`android`	📄`log`

❌	`3fe56e4`	#2	2019-09-10 23:15:31	~9 min	`ios`	📄`log`
❌	`3fe56e4`	#2	2019-09-10 23:20:27	~14 min	`android-e2e`	📄`log`
❌	`3fe56e4`	#2	2019-09-10 23:24:09	~17 min	`android`	📄`log`

❌	`88f971f`	#3	2019-09-13 11:06:57	~9 min	`ios`	📄`log`
❌	`88f971f`	#3	2019-09-13 11:11:17	~14 min	`android-e2e`	📄`log`
❌	`88f971f`	#3	2019-09-13 11:11:30	~14 min	`android`	📄`log`

✔️	`07fd799`	#4	2019-09-13 15:01:59	~9 min	`ios`	📦`ipa` 📲
✔️	`07fd799`	#4	2019-09-13 15:04:14	~11 min	`android`	📦`apk` 📲
✔️	`07fd799`	#4	2019-09-13 15:05:36	~13 min	`android-e2e`	📦`apk` 📲
✔️	`07fd799`	#1	2019-09-15 22:11:43	~10 min	`ios`	📦`ipa` 📲
✔️	`07fd799`	#1	2019-09-15 22:12:18	~11 min	`android`	📦`apk` 📲
✔️	`07fd799`	#1	2019-09-15 22:12:56	~11 min	`android-e2e`	📦`apk` 📲
❌	`07fd799`	#1	2019-09-17 06:54:22	~3 min	`windows`	📄`log`
❌	`07fd799`	#1	2019-09-17 06:56:46	~5 min	`macos`	📄`log`
❌	`07fd799`	#1	2019-09-17 06:57:34	~6 min	`linux`	📄`log`

❌	`d93edcf`	#2	2019-09-28 12:08:00	~38 sec	`android`	📄`log`
❌	`d93edcf`	#2	2019-09-28 12:08:01	~35 sec	`ios`	📄`log`
❌	`d93edcf`	#2	2019-09-28 12:08:04	~36 sec	`linux`	📄`log`
❌	`d93edcf`	#2	2019-09-28 12:08:07	~36 sec	`macos`	📄`log`
❌	`d93edcf`	#2	2019-09-28 12:08:10	~36 sec	`windows`	📄`log`
✔️	`d93edcf`	#2	2019-09-28 12:19:10	~11 min	`android-e2e`	📦`apk` 📲

❌	`aa7ce81`	#3	2019-09-29 10:05:53	~31 sec	`android`	📄`log`
❌	`aa7ce81`	#3	2019-09-29 10:05:58	~32 sec	`ios`	📄`log`
❌	`aa7ce81`	#3	2019-09-29 10:06:00	~31 sec	`linux`	📄`log`
❌	`aa7ce81`	#3	2019-09-29 10:06:05	~32 sec	`macos`	📄`log`
❌	`aa7ce81`	#3	2019-09-29 10:06:07	~32 sec	`windows`	📄`log`
❌	`aa7ce81`	#4	2019-09-29 10:06:07	~32 sec	`android`	📄`log`
❌	`aa7ce81`	#4	2019-09-29 10:16:20	~10 min	`android-e2e`	📄`log`

❌	`ee8e780`	#4	2019-09-29 14:56:15	~8 min	`macos`	📄`log`
✔️	`ee8e780`	#4	2019-09-29 14:58:42	~11 min	`ios`	📦`ipa` 📲
✔️	`ee8e780`	#4	2019-09-29 15:01:00	~13 min	`windows`	📦`exe`
✔️	`ee8e780`	#4	2019-09-29 15:01:37	~14 min	`linux`	📦`App`
✔️	`ee8e780`	#5	2019-09-29 15:02:44	~15 min	`android`	📦`apk` 📲
✔️	`ee8e780`	#5	2019-09-29 15:03:38	~16 min	`android-e2e`	📦`apk` 📲

✔️	`4a2a2db`	#5	2019-09-30 09:56:40	~11 min	`ios`	📦`ipa` 📲
✔️	`4a2a2db`	#5	2019-09-30 10:01:07	~15 min	`macos`	📦`dmg`
✔️	`4a2a2db`	#6	2019-09-30 10:06:38	~21 min	`android-e2e`	📦`apk` 📲
✔️	`4a2a2db`	#6	2019-09-30 10:08:55	~23 min	`android`	📦`apk` 📲
✔️	`4a2a2db`	#5	2019-09-30 10:09:42	~23 min	`windows`	📦`exe`
✔️	`4a2a2db`	#5	2019-09-30 10:09:48	~24 min	`linux`	📦`App`

✔️	`dccdccd`	#6	2019-09-30 12:39:09	~9 min	`ios`	📦`ipa` 📲
❌	`dccdccd`	#7	2019-09-30 12:42:25	~12 min	`android-e2e`	📄`log`
✔️	`dccdccd`	#6	2019-09-30 12:43:26	~13 min	`macos`	📦`dmg`
✔️	`dccdccd`	#6	2019-09-30 12:43:38	~13 min	`linux`	📦`App`
❌	`dccdccd`	#7	2019-09-30 12:43:40	~13 min	`android`	📄`log`
✔️	`dccdccd`	#6	2019-09-30 12:47:27	~17 min	`windows`	📦`exe`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`bdc6152`	#7	2019-10-01 21:04:36	~2 min	`windows`	📄`log`
❌	`bdc6152`	#7	2019-10-01 21:04:37	~3 min	`macos`	📄`log`
❌	`bdc6152`	#7	2019-10-01 21:04:47	~3 min	`linux`	📄`log`
✔️	`bdc6152`	#7	2019-10-01 21:11:49	~10 min	`ios`	📦`ipa` 📲
❌	`bdc6152`	#8	2019-10-01 21:15:10	~13 min	`android`	📄`log`
✔️	`bdc6152`	#8	2019-10-01 21:16:16	~14 min	`android-e2e`	📦`apk` 📲
✔️	`bdc6152`	#9	2019-10-02 07:41:38	~12 min	`android`	📦`apk` 📲

✔️	`8ba3920`	#8	2019-10-02 11:32:04	~11 min	`ios`	📦`ipa` 📲
✔️	`8ba3920`	#9	2019-10-02 11:32:56	~12 min	`android-e2e`	📦`apk` 📲
✔️	`8ba3920`	#10	2019-10-02 11:33:48	~13 min	`android`	📦`apk` 📲
✔️	`8ba3920`	#8	2019-10-02 11:34:10	~13 min	`macos`	📦`dmg`
✔️	`8ba3920`	#8	2019-10-02 11:34:13	~13 min	`linux`	📦`App`
✔️	`8ba3920`	#8	2019-10-02 11:35:34	~14 min	`windows`	📦`exe`

errorists · 2019-09-10T08:17:02Z

thanks @alexjg
I'll take a more thorough look once the iOS build is ready, in the meantime judging by the attached screenshot the only issues I could find were:

• The reply icon is displayed at incorrect size (I'm guessing 20), it should be 16 by 16
• The close icon is using the incorrect asset, this is the right one. Not a huge difference, I wouldn't blame anyone for not spotting it :)
• Can we change the colour of the border at the top of the reply/chat toolbar to Light Grey, similar to how we use it elsewhere in the app?

alexjg · 2019-09-10T14:04:21Z

@errorists That asset looks like it's not been added to the app (that is, I can't see a close-circle asset). I can't seem to go the the master component from Figma (getting a 404). Where should I get the asset and are there any conventions I should be aware of when adding it to the iOS and Android projects?

errorists · 2019-09-10T14:11:46Z

it's cool, I've exported it here. As far as I can tell, we use PNGs, at 1x,2x,3x densities and tint it to get the correct colour. Alternatively, you can try and sample the close icon located under the Browser tab. It might be that it's made with a circular grey view and 'X' icon added on top, not sure, best to ask @flexsurfer

flexsurfer · 2019-09-10T14:42:59Z

yes it's just a view with the icon, you can find it here https://github.com/status-im/status-react/blob/d07c9c6613551a6b68ff1087276f08aa64f61a71/src/status_im/ui/screens/browser/open_dapp/views.cljs#L49

alexjg · 2019-09-10T23:06:42Z

Thanks for that, I've implemented it in a similar manner. I've also fixed the top border and the reply icon size. Let me know if anything else needs doing.

errorists · 2019-09-13T07:20:25Z

looks good @alexjg !
@flexsurfer is there anything we can do to 'unstuck' the iOS build so it's ready to test?

flexsurfer · 2019-09-13T10:19:14Z

@alexjg could you please rebase onto develop and squash commits, thanks

alexjg · 2019-09-13T11:01:39Z

Done

yenda · 2019-09-13T12:24:37Z

@alexjg linter is complaining about your recent changes, you can use lein cljfmt fix to fix it.

src/status_im/ui/screens/chat/styles/input/input.cljs

alexjg · 2019-09-13T14:53:00Z

@alexjg linter is complaining about your recent changes, you can use lein cljfmt fix to fix it.

Done

statustestbot · 2019-09-13T15:26:19Z

96% of end-end tests have passed

Total executed tests: 46
Failed tests: 2
Passed tests: 44

Failed tests (2)

Click to expand

1. test_text_message_1_1_chat
Device 1: Tap on NextButton Device 1: Tap on MaybeLaterButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 2: Steps, video, logs Failure screenshot Device 1: Steps, video, logs Failure screenshot
2. test_long_press_to_delete_public_chat
Device 1: Looking for a message by text: 'test message' Device 1: Wait for ChatElementByText `Chat history is shown` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (44)

Click to expand

1. test_block_user_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
3. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
4. test_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
5. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
6. test_open_transaction_on_etherscan
Device sessions Device 1: Steps, video, logs
7. test_public_chat_messaging
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_long_press_to_delete_1_1_chat
Device sessions Device 1: Steps, video, logs
9. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
10. test_add_to_contacts
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_sign_typed_message
Device sessions Device 1: Steps, video, logs
12. test_unread_messages_counter_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
13. test_ens_in_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
14. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
15. test_send_message_in_group_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
16. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
17. test_send_token_with_7_decimals
Device sessions Device 1: Steps, video, logs
18. test_offline_messaging_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
19. test_modify_transaction_fee_values
Device sessions Device 1: Steps, video, logs
20. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
21. test_add_account_to_multiaccount_instance
Device sessions Device 1: Steps, video, logs
22. test_manage_assets
Device sessions Device 1: Steps, video, logs
23. test_send_emoji
Device sessions Device 1: Steps, video, logs
24. test_search_chat_on_home
Device sessions Device 1: Steps, video, logs
25. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
26. test_can_add_existing_ens
Device sessions Device 1: Steps, video, logs
27. test_messaging_in_different_networks
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
28. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
29. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
30. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
31. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
32. test_start_chat_with_ens
Device sessions Device 1: Steps, video, logs
33. test_add_contact_from_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
34. test_send_two_transactions_one_after_another_in_dapp
Device sessions Device 1: Steps, video, logs
35. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
36. test_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
37. test_offline_status
Device sessions Device 1: Steps, video, logs
38. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
39. test_unread_messages_counter_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
40. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
41. test_user_can_remove_profile_picture
Device sessions Device 1: Steps, video, logs
42. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
43. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs
44. test_backup_recovery_phrase_warning_from_wallet
Device sessions Device 1: Steps, video, logs

flexsurfer · 2019-09-13T15:28:00Z

@errorists ios ready to test

yenda · 2019-09-17T21:34:40Z

@flexsurfer @errorists wasn't it tested already? can we merge?

errorists · 2019-09-18T04:31:43Z

In the testing I just did, the reply icon is not displayed at all. Other than that I couldn’t find any issues

yenda · 2019-09-28T12:04:38Z

Hey @alexjg are you still planning on finishing this PR?
I resolved the conflict for you, but I can't commit my suggestion to fix the underscore issue because it is on your repo. Once you accept it please squash everything into one commit and push

alexjg · 2019-09-28T14:04:10Z

@yenda yep, I've been on holiday for the past few days, hence slow replies. I'll squash once I'm home tomorrow.

alexjg · 2019-09-29T14:51:16Z

@yenda I've squashed and pushed.

One thing I've noticed is that the recent gfycat changes mean that the address of the account you're responding to appears rather than the gfycat of it. I'm not sure if this is a bug or not and it definitely seems unrelated to the functionality implemented here but I thought I would mention it.

Everything should be hunky dory for merge now.

churik · 2019-09-30T09:04:32Z

@yenda can you review it again?
I'll check briefly after and we can merge

yenda · 2019-09-30T09:17:40Z

@churik the code looks fine but the result isn't great because of the reply bug. I tried to fix it quickly but it is not that easy. As @alexjg mentions it comes from the username/identicons changes

churik · 2019-09-30T09:21:50Z

@yenda
In this case please just ping me here when I can test it again.

statustestbot · 2019-09-30T09:38:04Z

89% of end-end tests have passed

Total executed tests: 47
Failed tests: 5
Passed tests: 42

Failed tests (5)

Click to expand

1. test_send_transaction_from_daap
Device 1: Wait for OkButton Device 1: Tap on OkButton `Balance is not changed during 360 seconds, funds were not received!` Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_send_token_with_7_decimals
Device 1: Wait for OkButton Device 1: Tap on OkButton `Transaction with amount 0.0480191 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D` Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_modify_transaction_fee_values
Device 1: Wait for OkButton Device 1: Tap on OkButton `Transaction with amount 0.003092516 is not found in list of transactions, address is b92496fffd668c2de08694623303456aa98cdf33` Device sessions Device 1: Steps, video, logs Failure screenshot
4. test_send_eth_from_wallet_to_address
Device 1: Wait for OkButton Device 1: Tap on OkButton `Transaction with amount 0.003091057 is not found in list of transactions, address is 9164f86170290ba3080e37d19d1953d3c5945913` Device sessions Device 1: Steps, video, logs Failure screenshot
5. test_send_stt_from_wallet
Device 1: Wait for OkButton Device 1: Tap on OkButton `Transaction with amount 0.003092559 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (42)

Click to expand

1. test_block_user_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
3. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
4. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
5. test_open_transaction_on_etherscan
Device sessions Device 1: Steps, video, logs
6. test_public_chat_messaging
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_long_press_to_delete_1_1_chat
Device sessions Device 1: Steps, video, logs
8. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
9. test_text_message_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
10. test_add_to_contacts
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
11. test_sign_typed_message
Device sessions Device 1: Steps, video, logs
12. test_unread_messages_counter_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
13. test_ens_in_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
14. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
15. test_send_message_in_group_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
16. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
17. test_offline_messaging_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
18. test_add_account_to_multiaccount_instance
Device sessions Device 1: Steps, video, logs
19. test_manage_assets
Device sessions Device 1: Steps, video, logs
20. test_long_press_to_delete_public_chat
Device sessions Device 1: Steps, video, logs
21. test_send_emoji
Device sessions Device 1: Steps, video, logs
22. test_search_chat_on_home
Device sessions Device 1: Steps, video, logs
23. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
24. test_can_add_existing_ens
Device sessions Device 1: Steps, video, logs
25. test_messaging_in_different_networks
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
26. test_logcat_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
27. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
28. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
29. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
30. test_start_chat_with_ens
Device sessions Device 1: Steps, video, logs
31. test_add_contact_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
32. test_send_two_transactions_one_after_another_in_dapp
Device sessions Device 1: Steps, video, logs
33. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
34. test_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
35. test_offline_status
Device sessions Device 1: Steps, video, logs
36. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
37. test_unread_messages_counter_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
38. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
39. test_user_can_remove_profile_picture
Device sessions Device 1: Steps, video, logs
40. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
41. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs
42. test_backup_recovery_phrase_warning_from_wallet
Device sessions Device 1: Steps, video, logs

alexjg · 2019-09-30T11:03:19Z

Is there anything I can do to move this forward? Or is it a case of waiting for a fix for the identicons issue which is being worked on elsewhere? I'm happy to have a look at the identicons issue myself if no one is doing so already.

yenda · 2019-09-30T12:23:16Z

@alexjg can you include this small change in your PR https://github.com/status-im/status-react/pull/9076/files ? It is not the right fix because the alias will show as a username but at least it won't show a public key instead of the name

alexjg · 2019-09-30T12:30:12Z

@yenda done

yenda · 2019-09-30T13:21:31Z

src/status_im/ui/screens/chat/utils.cljs

-    :else
-    [react/text {:style {:color colors/gray :font-size 12 :font-weight "400"}}
-     from]))
+  (let [additional-styles (style false)]


sorry one last thing are you sure this is actually necessary? what is this argument for? I can't find anywhere where it is true, I'm wondering if we couldn't remove the whole chosen? param in these styles fns

Yeah it doesn't seem like it's used anywhere but I wasn't completely confident of that (given my inexperience with the codebase) so I made the smallest change I could. It certainly does seem like we could remove the chosen? parameter, want me to go ahead and do that?

@flexsurfer

I'm out this week ill let @flexsurfer decide

alexjg · 2019-10-01T20:17:39Z

@yenda is there anything remaining to be done to get this merged? I'm keen to get it done as the gitcoin bounty attached to it expires in 2 days.

alexjg · 2019-10-01T21:01:47Z

I've rebased from develop and the indenticon issue looks to be solved.

churik · 2019-10-02T07:55:51Z

Tested on IOS 11.4.1. and Android 8 (LG V20):

reply screen with long messages
custom user pictures
different types of chats

From my POV can be merged.
@flexsurfer can you review it please or we need to wait @yenda approve anyway?

yenda is off

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>

alexjg requested a review from a team as a code owner September 9, 2019 23:31

auto-assign bot removed the request for review from a team September 9, 2019 23:31

flexsurfer added bounty community labels Sep 10, 2019

flexsurfer requested a review from yenda September 10, 2019 07:14

alexjg force-pushed the fix-compose-reply-ui branch from 3fe56e4 to 88f971f Compare September 13, 2019 10:56

yenda reviewed Sep 13, 2019

View reviewed changes

src/status_im/ui/screens/chat/styles/input/input.cljs Show resolved Hide resolved

alexjg force-pushed the fix-compose-reply-ui branch from 88f971f to 07fd799 Compare September 13, 2019 14:52

yenda approved these changes Sep 13, 2019

View reviewed changes

gitcoinbot mentioned this pull request Sep 13, 2019

Fixes to UI for composing a reply #7781

Closed

9 tasks

weekly-digest bot mentioned this pull request Sep 29, 2019

Weekly Digest (22 September, 2019 - 29 September, 2019) #9066

Closed

alexjg force-pushed the fix-compose-reply-ui branch from aa7ce81 to ee8e780 Compare September 29, 2019 14:47

alexjg force-pushed the fix-compose-reply-ui branch from ee8e780 to 4a2a2db Compare September 30, 2019 09:45

alexjg force-pushed the fix-compose-reply-ui branch from 4a2a2db to dccdccd Compare September 30, 2019 12:29

yenda reviewed Sep 30, 2019

View reviewed changes

alexjg force-pushed the fix-compose-reply-ui branch from dccdccd to bdc6152 Compare October 1, 2019 21:01

flexsurfer approved these changes Oct 2, 2019

View reviewed changes

flexsurfer requested a review from yenda October 2, 2019 10:56

flexsurfer force-pushed the fix-compose-reply-ui branch from bdc6152 to 8ba3920 Compare October 2, 2019 11:20

Fix small UI problems with the compose reply screen

78c57a3

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>

flexsurfer force-pushed the fix-compose-reply-ui branch from 8ba3920 to 78c57a3 Compare October 2, 2019 11:21

flexsurfer merged commit 78c57a3 into status-im:develop Oct 2, 2019

weekly-digest bot mentioned this pull request Oct 6, 2019

Weekly Digest (29 September, 2019 - 6 October, 2019) #9110

Closed

errorists mentioned this pull request Oct 14, 2019

[Onboarding] Welcome screens #8135

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix small UI problems with the compose reply screen #8959

Fix small UI problems with the compose reply screen #8959

alexjg commented Sep 9, 2019

status-github-bot bot commented Sep 9, 2019

status-github-bot bot commented Sep 9, 2019

status-im-auto commented Sep 9, 2019 •

edited

Loading

errorists commented Sep 10, 2019 •

edited

Loading

alexjg commented Sep 10, 2019

errorists commented Sep 10, 2019

flexsurfer commented Sep 10, 2019

alexjg commented Sep 10, 2019 •

edited

Loading

errorists commented Sep 13, 2019

flexsurfer commented Sep 13, 2019

alexjg commented Sep 13, 2019

yenda commented Sep 13, 2019

alexjg commented Sep 13, 2019

statustestbot commented Sep 13, 2019

flexsurfer commented Sep 13, 2019

yenda commented Sep 17, 2019

errorists commented Sep 18, 2019

yenda commented Sep 28, 2019 •

edited

Loading

alexjg commented Sep 28, 2019

alexjg commented Sep 29, 2019

churik commented Sep 30, 2019

yenda commented Sep 30, 2019

churik commented Sep 30, 2019

statustestbot commented Sep 30, 2019

alexjg commented Sep 30, 2019

yenda commented Sep 30, 2019

alexjg commented Sep 30, 2019

yenda Sep 30, 2019

alexjg Sep 30, 2019

yenda Oct 2, 2019

yenda Oct 2, 2019 •

edited

Loading

alexjg commented Oct 1, 2019

alexjg commented Oct 1, 2019

churik commented Oct 2, 2019

Fix small UI problems with the compose reply screen #8959

Fix small UI problems with the compose reply screen #8959

Conversation

alexjg commented Sep 9, 2019

Summary

status-github-bot bot commented Sep 9, 2019

status-github-bot bot commented Sep 9, 2019

Pull Request Checklist

status-im-auto commented Sep 9, 2019 • edited Loading

Jenkins Builds

errorists commented Sep 10, 2019 • edited Loading

alexjg commented Sep 10, 2019

errorists commented Sep 10, 2019

flexsurfer commented Sep 10, 2019

alexjg commented Sep 10, 2019 • edited Loading

errorists commented Sep 13, 2019

flexsurfer commented Sep 13, 2019

alexjg commented Sep 13, 2019

yenda commented Sep 13, 2019

alexjg commented Sep 13, 2019

statustestbot commented Sep 13, 2019

96% of end-end tests have passed

Failed tests (2)

Passed tests (44)

flexsurfer commented Sep 13, 2019

yenda commented Sep 17, 2019

errorists commented Sep 18, 2019

yenda commented Sep 28, 2019 • edited Loading

alexjg commented Sep 28, 2019

alexjg commented Sep 29, 2019

churik commented Sep 30, 2019

yenda commented Sep 30, 2019

churik commented Sep 30, 2019

statustestbot commented Sep 30, 2019

89% of end-end tests have passed

Failed tests (5)

Passed tests (42)

alexjg commented Sep 30, 2019

yenda commented Sep 30, 2019

alexjg commented Sep 30, 2019

yenda Sep 30, 2019

Choose a reason for hiding this comment

alexjg Sep 30, 2019

Choose a reason for hiding this comment

yenda Oct 2, 2019

Choose a reason for hiding this comment

yenda Oct 2, 2019 • edited Loading

Choose a reason for hiding this comment

alexjg commented Oct 1, 2019

alexjg commented Oct 1, 2019

churik commented Oct 2, 2019

status-im-auto commented Sep 9, 2019 •

edited

Loading

errorists commented Sep 10, 2019 •

edited

Loading

alexjg commented Sep 10, 2019 •

edited

Loading

yenda commented Sep 28, 2019 •

edited

Loading

yenda Oct 2, 2019 •

edited

Loading